Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Nested Content not rendering #11145

Merged
merged 3 commits into from
Sep 21, 2021

Conversation

madsrasmussen
Copy link
Contributor

This PR fixes the rendering of nested content after the tabs feature has been added. To prevent any breaking changes, we had to limit the allowed nested content groups to generic groups. Tabs and groups inside a tab are not supported in nested content. The Block List Editor can be used if tab support is needed.

How to test:

  • Create an element type with a generic group, a tab, and a group inside the tab
  • Set up a doctype with nested content.
  • Make sure you can only select the group from "Generic" in nested content.
  • Make sure nested content renders correctly in the content section.

fixes #11114

@Zeegaan Zeegaan self-requested a review September 21, 2021 10:30
@Zeegaan
Copy link
Member

Zeegaan commented Sep 21, 2021

Tested this both in v8 and v9 and it works great!

Code looks good to me 🤓

@Zeegaan Zeegaan merged commit 3ad2e74 into v8/dev Sep 21, 2021
@Zeegaan Zeegaan deleted the v8/bugfix/11114-nested-content-not-rendering branch September 21, 2021 11:07
@Zeegaan
Copy link
Member

Zeegaan commented Sep 21, 2021

This PR also fixes: #11083

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants