Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept udt as extension in import document type #11108

Merged

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Sep 15, 2021

Prerequisites

  • I have added steps to test this contribution in the description below

Description

Similar to the fix in #11061 this also pass in invalidfiles to handleFiles function ... and further fix the accepted extension.
https://stackoverflow.com/questions/34128497/ngf-pattern-not-working-for-ng-file-upload/34128573#34128573

According to the docs https://github.com/danialfarid/ng-file-upload#full-reference ngf-change has these parameters:

ngf-change="upload($files, $file, $newFiles, $duplicateFiles, $invalidFiles, $event)"

Before

image

After

image

We can still switch to all files and select e.g. a start.svg, which would return an array on a single obj when logging to console:

$scope.handleFiles = function (files, event, invalidFiles) {
      console.log("handleFiles", files, event, invalidFiles);
      if (files && files.length > 0) {
          $scope.upload(files[0]);
      }
};

image

@umbrabot
Copy link

umbrabot commented Sep 15, 2021

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@bjarnef bjarnef changed the title Import document type extension Accept udt as extension in import document type Sep 15, 2021
Copy link
Contributor

@nathanwoulfe nathanwoulfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bjarnef, this looks fine to me - system dialog defaults to .udt files, Umbraco provides UI feedback if I select an invalid file.

I've added a commit to fix the help text, which referenced a browse button as well as the import button, but only the latter exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants