Fixed issue with CachedPartial that cached an unmaterialized value #10832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat could not be used on cache hits.
|
Tested it, and this solution fixes the issue! Code makes sense to me 👍 |
Zeegaan
deleted the
v9/bugfix/cached_partial_did_not_materialize_before_caching
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed issue with CachedPartial that did only work in cache misses.
The reason was that the value cached was un-materialized. Fix is to materialize as HtmlString before we cache.
Also changed timeout parameter from
intto timespan.Test notes
, eghej.cshtml`@await Html.CachedPartialAsync("hej", null, TimeSpan.FromSeconds(20))