Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password tip not updated correct on init #10814

Merged
merged 4 commits into from
Aug 17, 2021

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Aug 8, 2021

Prerequisites

  • I have added steps to test this contribution in the description below

Description

PR #9256 introduced a <umb-password-tip>. However it wasn't updated correct on init. For example when creating a new member Umbraco generate a minimum password length, by default 10 characters, but the password tip says 10 characters were "Minimum 10 character(s) to go!"

First when updating password and keyup was triggered the password tip was updated.

Furthermore is was unnecessary to render value in curly brackets {{vm.passwordTip}} when using ng-bind-html="vm.passwordTip".

Before

maYoTrCUpZ

After

yu1RcMmJd1

@umbrabot
Copy link

umbrabot commented Aug 8, 2021

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link
Contributor

@nathanwoulfe nathanwoulfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bjarnef, fixes the issue nicely

@nathanwoulfe
Copy link
Contributor

However, a related issue - when selecting a value from the browser's autofill suggestions (ie Chrome's suggested strong password), the tooltip is not triggered because the $onChanges event is never raised. It's a browser issue, not an AngularJs or Umbraco-implementation issue, so can be a bit tricky to resolve. Doesn't need to block this fix, but probably needs consideration in the future.

@nathanwoulfe nathanwoulfe merged commit f4504d7 into umbraco:v8/contrib Aug 17, 2021
@bjarnef bjarnef deleted the v8/bug/password-tip-init branch August 17, 2021 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants