Removes inert
attribute when editorService.closeAll()
is called
#10710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #10708
Description
Removes the
inert
attribute on#mainWrapper
wheneditorService.closeAll()
is called.This code is necessary because when
closeAll
is called, there is no editor passed inargs
, and soremoveEditor
is never called, and so thefocusLockService.removeInertAttribute();
method isn't called either.This ensures
focusLockService.removeInertAttribute();
is called if the editor arg is null, meaning it's come from acloseAll
call.To test, open a dialog via
editorService.open
and then calleditorService.closeAll
. The main editor window should have theinert
attribute added and then removed once closed.