Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Amends for the Content Info Tab #10541

Merged
merged 17 commits into from
Aug 6, 2021
Merged

Accessibility Amends for the Content Info Tab #10541

merged 17 commits into from
Aug 6, 2021

Conversation

RachBreeze
Copy link
Contributor

As a result of investigating #8704 I have added an alias for the content info tab to ensure that the template drop down is labelled correctly.

I have also added a space on the open buttons to ensure that the copy reads better than shown below.
image

Finally I have removed the title attributes on the links in umb-node-preview as they held duplicate (but unlocalised) content as the link text and could result in some screen reader users hearing duplicate messages.

RachBreeze and others added 17 commits August 22, 2020 16:15
Merge latest Umbraco v8 into my repo
…into v8/contrib

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
… technology knows when a url retrieve has been succesfull.

Added labels for the controls
Preview reload only triggered if the values for height and width change
… link content and resulted in the copy being read twice

Removed returns and added spaces on the screen reader only attribute to ensure that the link text was followed by a space in the text (eg Open Product rather than OpenProduct for opening a document type called product)
@umbrabot
Copy link

umbrabot commented Jun 27, 2021

Hi there @RachBreeze, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@nul800sebastiaan nul800sebastiaan merged commit 9b57ec5 into umbraco:v8/contrib Aug 6, 2021
@nul800sebastiaan
Copy link
Member

Thanks very much @RachBreeze 👍

@bjarnef
Copy link
Contributor

bjarnef commented Aug 6, 2021

@RachBreeze @nul800sebastiaan I noticed at least one reference here, where <localize /> directive was self-closing. It is a custom HTML element, so it should have a end-closing tag similar to web component.

<localize></localize>

Self-closing elements are valid for a limited set og HTML elements like input, br, img etc.

@nul800sebastiaan
Copy link
Member

Thanks @bjarnef - I overlooked that one! 😅 Fixed: f7dee7e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants