-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility Amends for the Content Info Tab #10541
Accessibility Amends for the Content Info Tab #10541
Conversation
Merge latest Umbraco v8 into my repo
…into v8/contrib # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
… technology knows when a url retrieve has been succesfull. Added labels for the controls Preview reload only triggered if the values for height and width change
… link content and resulted in the copy being read twice Removed returns and added spaces on the screen reader only attribute to ensure that the link text was followed by a space in the text (eg Open Product rather than OpenProduct for opening a document type called product)
Hi there @RachBreeze, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Thanks very much @RachBreeze 👍 |
@RachBreeze @nul800sebastiaan I noticed at least one reference here, where
Self-closing elements are valid for a limited set og HTML elements like input, br, img etc. |
As a result of investigating #8704 I have added an alias for the content info tab to ensure that the template drop down is labelled correctly.
I have also added a space on the open buttons to ensure that the copy reads better than shown below.
Finally I have removed the title attributes on the links in
umb-node-preview
as they held duplicate (but unlocalised) content as the link text and could result in some screen reader users hearing duplicate messages.