Fix GetCropUrl() extension methods on UrlHelper #10527
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #10402.
Description
With the introduction of the new Media picker (v3 - with local crops), a new
GetCropUrl()
extension method onUrlHelper
was added that causes aThe call is ambiguous between the following methods or properties
compiler error when used with named parameters.This PR aligns the extension methods/parameters on
UrlHelper
with those onIPublishedContent
. Some code might still need updating, but the impact would be a lot lower (as the new extension method has less parameters that can cause ambiguity) and the change will be a lot easier: