Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update keyboard.service.js #10347

Closed
wants to merge 1 commit into from
Closed

Update keyboard.service.js #10347

wants to merge 1 commit into from

Conversation

nathanwoulfe
Copy link
Contributor

don't update default opts - missing this in merging #10023 10023

@nathanwoulfe
Update keyboard.service.js
e3b3614 
assign to empty object, don't updated default options
@bjarnef
Copy link
Contributor

bjarnef commented May 28, 2021

@nathanwoulfe should this have been merged instead of closed?
https://github.com/umbraco/Umbraco-CMS/blob/v8/contrib/src/Umbraco.Web.UI.Client/src/common/services/keyboard.service.js#L266-L267

@nathanwoulfe
Copy link
Contributor Author

@bjarnef this is the same fix as I need to get into #10023 but if I create the PR I can't self-approve, so didn't want to be waiting for it to get picked up, hence my comment on #10023 asking if you could submit the PR, then I can approve and merge 😄

@bjarnef bjarnef mentioned this pull request May 28, 2021
Merged
1 task
@ronaldbarendse ronaldbarendse deleted the nathanwoulfe-patch-2 branch May 28, 2021 07:08
@bjarnef
Copy link
Contributor

bjarnef commented May 28, 2021

@nathanwoulfe ahh okay, fixed in #10348 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanwoulfe @bjarnef