Shows a warning for people tempted to switch from the Obsolete to the new MediaPicker(v3) #10334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjarnef
reviewed
May 26, 2021
| @@ -8,6 +8,9 @@ namespace Umbraco.Web.PropertyEditors | |||
| /// </summary> | |||
| public class MediaPickerConfiguration : IIgnoreUserStartNodesConfig | |||
| { | |||
| [ConfigurationField("notice", "You can NOT change the property editor", "obsoletemediapickernotice")] | |||
| public bool Notice { get; set; } | |||
|
|
|||
There was a problem hiding this comment.
@nul800sebastiaan I think this should be defined as string.
There was a problem hiding this comment.
sure but it doesn't really matter, it's not a REAL prevalue, just a hack to show a warning for now while we think of a betters solution. 😄
|
I see the good intention, but isn't this the case for most data editors already? |
|
I think it's valuable since previous obsolete editors can be swapped out - ContentPicker for ContentPicker2, for example, works fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in relation to #10308, please read that first.
Which looks like this: