Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved accessibility of link picker #10099

Merged
merged 17 commits into from
Apr 6, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
3a031e8
Merge pull request #1 from umbraco/v8/contrib
RachBreeze Aug 22, 2020
c708b37
Merge branch 'v8/contrib' of https://github.com/RachBreeze/Umbraco-CM…
Oct 7, 2020
0b49cd0
Merge branch 'v8/contrib' of https://github.com/umbraco/Umbraco-CMS i…
Oct 22, 2020
e395a42
Merge branch 'v8/contrib' of https://github.com/umbraco/Umbraco-CMS i…
Oct 25, 2020
d988bc6
Merge branch 'v8/contrib' of https://github.com/umbraco/Umbraco-CMS i…
Oct 26, 2020
35b9897
Merge branch 'v8/contrib' of https://github.com/umbraco/Umbraco-CMS i…
Oct 31, 2020
81d9665
Merge branch 'v8/contrib' of https://github.com/umbraco/Umbraco-CMS i…
Nov 19, 2020
5d2e0b5
Merge branch 'v8/contrib' of https://github.com/umbraco/Umbraco-CMS i…
Dec 17, 2020
251ea27
Merge branch 'v8/contrib' of https://github.com/umbraco/Umbraco-CMS i…
Jan 4, 2021
1186f1b
Merge branch 'v8/contrib' of https://github.com/umbraco/Umbraco-CMS i…
Jan 18, 2021
0bade7d
Added support for screeen reader alerts on the embed so that assitive…
Jan 31, 2021
4a8735d
Merge branch 'v8/contrib' of https://github.com/umbraco/Umbraco-CMS i…
Feb 13, 2021
f90fb99
Merge branch 'v8/contrib' of https://github.com/umbraco/Umbraco-CMS i…
Feb 28, 2021
aec2a86
Merge branch 'v8/contrib' of https://github.com/umbraco/Umbraco-CMS i…
Apr 4, 2021
fdaa7d8
Added control ids for the link picker
Apr 4, 2021
457d329
Merge branch 'v8/contrib' into pr/10099
mikecp Apr 6, 2021
496cc1c
Add French translation
mikecp Apr 6, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ function treeSearchBox(localizationService, searchService, $q) {
datatypeKey: "@",
hideSearchCallback: "=",
searchCallback: "=",
inputId: "@",
autoFocus: "="
},
restrict: "E", // restrict to an element
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,81 +16,84 @@

<div ng-class="{'flex': showAnchor}">

<umb-control-group label="@defaultdialogs_urlLinkPicker" class="umb-linkpicker__url">
<umb-control-group label="@defaultdialogs_urlLinkPicker" class="umb-linkpicker__url" alias="urlLinkPicker">
<input type="text"
style="margin-right: 10px;"
localize="placeholder"
placeholder="@general_url"
class="umb-property-editor umb-textstring"
ng-model="model.target.url"
umb-auto-focus
ng-disabled="model.target.id || model.target.udi" />
ng-disabled="model.target.id || model.target.udi"
id="urlLinkPicker"/>
</umb-control-group>

<umb-control-group label="@defaultdialogs_anchorLinkPicker" class="umb-linkpicker__anchor" ng-if="showAnchor">
<umb-control-group label="@defaultdialogs_anchorLinkPicker" class="umb-linkpicker__anchor" ng-if="showAnchor" alias="anchor">
<input type="text"
list="anchors"
localize="placeholder"
placeholder="@placeholders_anchor"
class="umb-property-editor umb-textstring"
ng-model="model.target.anchor" />
ng-model="model.target.anchor"
id="anchor"/>

<datalist id="anchors">
<option value="{{a}}" ng-repeat="a in anchorValues"></option>
</datalist>
</umb-control-group>
</div>

<umb-control-group label="@defaultdialogs_nodeNameLinkPicker">
<umb-control-group label="@defaultdialogs_nodeNameLinkPicker" alias="nodeNameLinkPicker">
<input type="text"
localize="placeholder"
placeholder="@placeholders_entername"
class="umb-property-editor umb-textstring"
ng-model="model.target.name" />
ng-model="model.target.name"
id="nodeNameLinkPicker"/>
</umb-control-group>

<umb-control-group ng-if="showTarget" label="@content_target">
<umb-control-group ng-if="showTarget" label="@content_target" alias="openInNewWindow">
<umb-checkbox
model="vm.openInNewWindow"
on-change="vm.toggleOpenInNewWindow(model, value)"
text="{{vm.labels.openInNewWindow}}">
text="{{vm.labels.openInNewWindow}}"
input-id="openInNewWindow">
</umb-checkbox>
</umb-control-group>

<div class="umb-control-group">
<h5><localize key="defaultdialogs_linkToPage">Link to page</localize></h5>

<div ng-hide="miniListView">
<umb-tree-search-box
hide-search-callback="hideSearch"
search-callback="onSearchResults"
search-from-id="{{searchInfo.searchFromId}}"
search-from-name="{{searchInfo.searchFromName}}"
datatype-key="{{searchInfo.dataTypeKey}}"
show-search="{{searchInfo.showSearch}}"
section="{{section}}">
<label for="treeSearch" class="sr-only"><localize key="visuallyHiddenTexts_searchContentTree">Search content tree</localize></label>
<umb-tree-search-box hide-search-callback="hideSearch"
search-callback="onSearchResults"
search-from-id="{{searchInfo.searchFromId}}"
search-from-name="{{searchInfo.searchFromName}}"
datatype-key="{{searchInfo.dataTypeKey}}"
show-search="{{searchInfo.showSearch}}"
section="{{section}}"
input-id="treeSearch">
</umb-tree-search-box>

<br />

<umb-tree-search-results
ng-if="searchInfo.showSearch"
results="searchInfo.results"
select-result-callback="selectResult"
empty-search-result-position="default">
<umb-tree-search-results ng-if="searchInfo.showSearch"
results="searchInfo.results"
select-result-callback="selectResult"
empty-search-result-position="default">
</umb-tree-search-results>

<div ng-hide="searchInfo.showSearch">
<umb-tree
section="content"
hideheader="true"
hideoptions="true"
api="dialogTreeApi"
on-init="onTreeInit()"
enablelistviewexpand="true"
isdialog="true"
enablecheckboxes="true"
customtreeparams="{{customTreeParams}}">
<umb-tree section="content"
hideheader="true"
hideoptions="true"
api="dialogTreeApi"
on-init="onTreeInit()"
enablelistviewexpand="true"
isdialog="true"
enablecheckboxes="true"
customtreeparams="{{customTreeParams}}"
id="treePicker">
</umb-tree>
</div>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<umb-icon icon="icon-search" class="icon icon-search" ng-if="showSearch == 'false'"></umb-icon>
<button type="button" class="btn-reset icon icon-arrow-left" ng-if="showSearch == 'true'" localize="title" title="@general_back" ng-click="hideSearch()"></button>
<input type="text"
id="{{inputId}}"
ng-model="term"
class="umb-search-field search-query -full-width-input"
placeholder="{{searchPlaceholderText}}"
Expand Down
1 change: 1 addition & 0 deletions src/Umbraco.Web.UI/Umbraco/config/lang/en.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2316,6 +2316,7 @@ To manage your website, simply open the Umbraco backoffice and start adding cont
<key alias="contextMenuDescription">Select one of the options to edit the node.</key>
<key alias="contextDialogDescription">Perform action %0% on the %1% node</key>
<key alias="addImageCaption">Add image caption</key>
<key alias="searchContentTree">Search content tree</key>
</area>
<area alias="references">
<key alias="tabName">References</key>
Expand Down
1 change: 1 addition & 0 deletions src/Umbraco.Web.UI/Umbraco/config/lang/en_us.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2335,6 +2335,7 @@ To manage your website, simply open the Umbraco backoffice and start adding cont
<key alias="contextMenuDescription">Select one of the options to edit the node.</key>
<key alias="contextDialogDescription">Perform action %0% on the %1% node</key>
<key alias="addImageCaption">Add image caption</key>
<key alias="searchContentTree">Search content tree</key>
</area>
<area alias="references">
<key alias="tabName">References</key>
Expand Down
1 change: 1 addition & 0 deletions src/Umbraco.Web.UI/Umbraco/config/lang/fr.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2212,6 +2212,7 @@ Pour gérer votre site, ouvrez simplement le backoffice Umbraco et commencez à
<key alias="newPartialView">Partial View</key>
<key alias="newPartialViewMacro">Macro de Partial View</key>
<key alias="newMember">Membre</key>
<key alias="searchContentTree">Chercher dans l'arborescence de contenu</key>
</area>
<area alias="references">
<key alias="tabName">Références</key>
Expand Down