Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9962: Use $allowedEditors instead of allowed #10086

Merged
merged 2 commits into from
Apr 4, 2021
Merged

9962: Use $allowedEditors instead of allowed #10086

merged 2 commits into from
Apr 4, 2021

Conversation

patrickdemooij9
Copy link
Contributor

If there's an existing issue for this PR then this fixes #9962

How to check (based on the default install):
Set all grid rows on "Allow all editors". Without this fix, you'll not be able to move between the different rows.

The issue here was that the .allow only has the editors selected by the user. So if you were to only select RTE, it would work because .allow is ["RTE"]. If you use the selectAll editors, it will set allowAll to true, but leave .allow empty.

@mikecp
Copy link
Contributor

mikecp commented Apr 1, 2021

Hello @patrickdemooij9 ,

Thanks for this PR!

It took me some time to find how to reproduce this, but eventually I ended up reproducing the behavior: this happens when reordering within/moving to a column which has the property maxItems set to a specific value.

For some reason, in "Allow All Editors" scenario,, when maxItems is not set, the value of area.Allowed is undefined, while it is an empty array [] when maxItems is specified.

This empty array creates an unexpected behavior in the test that follows, which basically checks that you are moving an allowed editor to the target cell or that you still have some space left for an extra editor in the target cell;

if (($.inArray(ui.item[0].getScope_HackForSortable().control.editor.alias, allowedEditors) < 0 && allowedEditors) ||
    (startingArea != area && area.maxItems != '' && area.maxItems > 0 && area.maxItems < area.controls.length + 1))

The check on moving an allowed editor works as expected when there is no maxItems specified, because in that case allowedEditors is undefined and therefore the check on && allowedEditors has the foreseen effect of making that part of the condition false anyway.
But when maxItems is specified and allowedEditors is an empty array, the test && allowedEditors will in fact evaluate to true and therefore the global check will take the first part of the condition into account, which returns true as well since allowedEditors is an empty array and the editor will not be found in the list... This makes the whole condition true and you enter in an incorrect "not allowed" scenario.

In addition to this, the condition itself seems written in the wrong order: why not first check to see if you are in an "allow all editors" scenario before (not) checking that you are moving an allowed editor?

All this to say that I have the impression that it might be more interesting to keep the area.allowed value but rewrite that first part of the condition.

So something like the following:

//var allowedEditors = area.allowed; /*Only one usage anymore so can directly be used in the condition */

if ((!area.allowAll && $.inArray(ui.item[0].getScope_HackForSortable().control.editor.alias, area.allowed) < 0) ||
   (startingArea != area && area.maxItems != '' && area.maxItems > 0 && area.maxItems < area.controls.length + 1)) {

Enough writing for now 😀
I am wondering what is your feeling about this?

@patrickdemooij9
Copy link
Contributor Author

Hey @mikecp,

Thanks for the response to the PR! I checked where the issue of the undefined and empty array is coming from. Apparently, the PostSave of the dataType is only sending the empty array in the request when the max items are set. Is this something that should be fixed too? I assume it should always send an empty array?

The check on moving an allowed editor works as expected when there is no maxItems specified, because in that case allowedEditors is undefined and therefore the check on && allowedEditors has the foreseen effect of making that part of the condition false anyway.
But when maxItems is specified and allowedEditors is an empty array, the test && allowedEditors will in fact evaluate to true and therefore the global check will take the first part of the condition into account, which returns true as well since allowedEditors is an empty array and the editor will not be found in the list... This makes the whole condition true and you enter in an incorrect "not allowed" scenario.

Is this true though? In the old scenario, it would indeed give a false statement (and true if the array existed) due to the allowedEditors check. But then the first part of the statement would give false anyway, right? I'll write some scenarios based on the old code: ($.inArray(ui.item[0].getScope_HackForSortable().control.editor.alias, allowedEditors) < 0 && allowedEditors

Scenario 1:
The .allowed returns ["rte", "textarea", "something"] and the item we are moving has the alias "textarea". This will then return true on both sides of the statement.

Scenario 2:
The .allowed returns undefined and the item we are moving has the alias "textarea". The $.inArray will return -1, making the first part of the statement false.

Scenario 3:
The .allowed returns [] and the item we are moving has the alias "textarea". The $.inArray will return -1, making the first part of the statement false.

It might be that I am missing something here, but I don't see how the statement returns true when the .allowed is an empty array. But please correct me if I am wrong!

And then the reason why I am using $allowedEditors here is that it already has the logic for the allowAll applied in it. That code for that is here: https://github.com/umbraco/Umbraco-CMS/blob/v8/contrib/src/Umbraco.Web.UI.Client/src/views/propertyeditors/grid/grid.controller.js#L848. And the $allowedEditors is also used in other parts of the code instead of .allowed. Yes, we can use .allowed here, but I think using $allowedEditors would be safer and more consistent here.

As for the if statement. It does look like I can tidy that up a bit better. With my change to the code, the &allowedEditors check is not needed anymore.

Let me know what you think!

@mikecp
Copy link
Contributor

mikecp commented Apr 4, 2021

Hey @patrickdemooij9 ,

Thanks for the clarification about your usage of $allowedEditors, it makes more sense to use it indeed! So it's all ready to merge 👍

Just for the record, I think you may have skipped the fact that the inArray condition checks on the result being less than 0, not greater than 0 😉

So in your scenario's for old behavior:
1/ inArray returns 1 which is not < 0 => evaluated to false
allowedEditors evaluated to true
=> result for that part of the condition is false, which is correct ("textarea" editor allowed)

2/ inArray < 0 => true
allowedEditors evaluated to false
=> result for that part is false, which is correct (all editors allowed)

3/ inArray < 0 => true
allowedEditors evaluated to true
=> result for that part is true, which is incorrect since all editors are allowed

This last scenario was indeed the situation that I mentioned that was creating the bug and preventing the move although all editors were allowed.

Thanks again for your PR! It will solve some tricky wrong behavior of the grid 👍

Cheers!

@mikecp mikecp merged commit f8e280e into umbraco:v8/contrib Apr 4, 2021
@patrickdemooij9
Copy link
Contributor Author

Hi @mikecp ,
You are correct about the scenarios being wrong. I totally looked over the < 0 instead of it being > 0 😅

Thanks for merging the PR. I am sure a lot of people will appreciate this fix

@mikecp
Copy link
Contributor

mikecp commented Apr 4, 2021

I think too 😀 👍

nathanwoulfe added a commit that referenced this pull request Apr 20, 2021
* Bump version to 8.6.8

* Initial rework of Lock dictionaries

* [Issue 5277-146] accessibility - Close 'X' icon next to language drop… (#9264)

* [Issue 5277-146] accessibility - Close 'X' icon next to language drop down is identified as "link" - screen reader

* add new loacalization key

* Fix issue with SqlMainDomLock that cannot use implicit lock timeouts … (#9973)

* Fix issue with SqlMainDomLock that cannot use implicit lock timeouts … (#9973)

(cherry picked from commit da5351d)

* Adjust unit tests and apply fixes to scope

* Add more unit tests, showing current issue

* Counting Umbraco.ModelsBuilder and ModelsBuilder.Umbraco namespaces as external providers

* Fix dead lock with TypeLoader

* Fix errors shown in unit tests

* Throw error if all scopes hasn't been disposed

* Clean

* Fixes and Updates for DB Scope and Ambient Context leaks (#9953)

* Adds some scope tests (ported back from netcore) and provides a much better error message, ensure execution context is not flowed to child tasks that shouldn't leak any current ambient context

* updates comment

* Ensure SqlMainDomLock suppresses execution context too

* Since we're awaiting a task in a library method, ConfigureAwait(false)

* missing null check

Co-authored-by: Elitsa Marinovska <[email protected]>

* Adds additional error checking and reporting to MainDom/SqlMainDomLock (#9954)

Co-authored-by: Elitsa Marinovska <[email protected]>

* Add copy logic to Media Picker (#9957)

* Add copy logic to Media Picker

* Add action for copy all

* Fix for selectable media item

* Wrap calls to map in scopes

* Autocomplete scopes

* Remove unnecessary aria-hidden attribute from <umb-icon>

* Remove scope from method that calls another method that has a scope

* Fixes #9993 - Cannot save empty image in Grid

* Clean

* Revert "The Value() method for IPublishedContent was not working with the defaultValue parameter" (#9989)

* Use a hashset to keep track of acquired locks

This simplifies disposing/checking for locks greatly.

* Add images in grid - fixes 9982 (#9987)

Co-authored-by: Sebastiaan Janssen <[email protected]>

* Only create the dicts and hashset when a lock is requested

* Clean

* Adds a config for configuring the access rules on the content dashboard - by default it granted for all user groups

* Adds additional params indicating whether user is admin

* Add images in grid - fixes 9982 (#9987)

Co-authored-by: Sebastiaan Janssen <[email protected]>
(cherry picked from commit e201977)

* Bump version to 8.12.2

* #9964 Removed unneeded check for HttpContext

* Fix for #9950 - HttpsCheck will now retry using the login background image if inital request returns 301/302. Excessvie Headers check will now check the root url instead of the backoffice

* Merge pull request #9994 from umbraco/v8/bugfix/9993

Fixes #9993 - Cannot save empty image in Grid

(cherry picked from commit 0ecc933)

* Apply suggestions from review

* Fixes #9983 - Getting kicked, if document type has a Umbraco.UserPicker property (#10002)

* Fixes #9983

Temporary fix for this issue. using the entityservice like before.

* Needed to remove the call to usersResource here as well for displaying the picked items

* Don't need usersResource for now

* Fixes #9983 - Getting kicked, if document type has a Umbraco.UserPicker property (#10002)

* Fixes #9983

Temporary fix for this issue. using the entityservice like before.

* Needed to remove the call to usersResource here as well for displaying the picked items

* Don't need usersResource for now

(cherry picked from commit 45de0a1)

* 8539: Allow alias in image cropper (#9266)

Co-authored-by: Owain Williams <[email protected]>

* Wrap dumping dictionaries in a method.

* Create method for generating log message

And remove forgotten comments.

* Fix swedish translation for somethingElse.

* Copy member type (#10020)

* Add copy dialog for member type

* Implement copy action for member type

* Create specific localization for content type, media type and member type

* Handle "foldersonly" querystring

* Add button type attribute

* Add a few missing changes of anchor to button element

* Null check on scope and options to ensure backward compatibility

* Improve performance, readability and handling of FollowInternalRedirects (#9889)

* Improve performance, readability and handling of FollowInternalRedirects

* Logger didn't like string param

Passing string param to _logger.Debug<PublishedRouter, int> wasn't happy. Changed to pass existing internalRedirectAsInt variable.

Co-authored-by: Nathan Woulfe <[email protected]>

* Update casing of listview layout name

* 9097 add contextual password helper (#9256)

* update back-office forms

* Display tip on reset password page as well

* add directive for password tip

* integrate directove in login screen

* forgot the ng-keyup :-)

* adapt tooltip directive to potential different Members and Users password settings

* remove watcher

Co-authored-by: Nathan Woulfe <[email protected]>

* Unbind listener

Listening for splitViewRequest was only unbound if the split view editor was opened. Not cleaning up the listener caused a memory leak when changing between nodes as the spit view editor was detached but not garbage-collected

* Replace icon in date picker with umb-icon component (#10040)

* Replace icon in date picker with <umb-icon> component

* Adjust height of clear button

* Update cypress and fix tests

* Listview config icons (#10036)

* Update icons to use <umb-icon> component

* Simplify markup and use disabled button

* Use move cursor style on sortable handle

* Add class for action column

* Update setting auto focus

* Increase font size of umb-panel-header-icon

* Anchor noopener (#10009)

* Set rel="noopener" for anchors with target="_blank"

* Reverted unwanted changes to Default.cshtml

* Align 'Add language' test to netcore

* Add new cypress tests

* Add indentation

* Getting rid of the config file and implementing an appSetting instead

* Implementation for IContentDashboardSettings

* Cleanup

* bool.Try

* Taking AllowContentDashboardAccessToAllUsers prop from GlobalSettings to ContentDashboardSettings and saving AccessRulesFromConfig into a backing field

* Handling multiple values per field in Examine Management

* Add Root<T> and Breadcrumbs extension methods for IPublishedContent (#9033)

* Fix usage of obsolete CreatorName and WriterName properties

* Add generic Root extension method

* Add Breadcrumbs extension methods

* Orders member type grouping of members alphabetically, matching the listing of member types.

* Revert updating deprecated WriterName/CreatorName refs

Changing the properties to use the extensions is a good thing (given the props are deprecated), but causes issues deep in tests. I'm reverting that change to fix the tests, and all refs to the deprecated properties should be updated in one sweep, to deal with any other test issues that might crop up.

* Handle Invalid format for Upgrade check

* Fixes tabbing-mode remains active after closing modal #9790 (#10074)

* Allow to pass in boolean to preventEnterSubmit directive (#8639)

* Pass in value to preventEnterSubmit directive

* Set enabled similar to preventDefault and preventEnterSubmit directives

* Update prevent enter submit value

* Init value from controller

* Use a different default input id prefix for umb-search-filter

* Fix typo

* Check for truthly value

* Revert "Set enabled similar to preventDefault and preventEnterSubmit directives"

This reverts commit 536ce85.

* None pointer events when clicking icon

* Use color variable

* Fixes tabbing-mode remains active after closing modal #9790 (#10074)

(cherry picked from commit c881fa9)

* Null check on scope and options to ensure backward compatibility

(cherry picked from commit fe8cd23)

* Fix validation of step size in integer/numeric field

* 9962: Use $allowedEditors instead of allowed (#10086)

* 9962: Use $allowedEditors instead of allowed

* 9962: Remove redundant statement

* fixes #10021 adds ng-form and val-form-manager to the documentation

* Improved accessibility of link picker (#10099)

* Added support for screeen reader alerts on the embed so that assitive technology knows when a url retrieve has been succesfull.
Added labels for the controls
Preview reload only triggered if the values for height and width change

* Added control ids for the link picker

* Add French translation

* Accessibility: Alerts the user how many results have been returned on a tree search (#10100)

* Added support for screeen reader alerts on the embed so that assitive technology knows when a url retrieve has been succesfull.
Added labels for the controls
Preview reload only triggered if the values for height and width change

* Tree search details the number of search items returned

* Add French translations

* Updated LightInject to v6.4.0

* Remove HtmlSanitizer once more - see #9803

* Also make sure NuGet installs the correct version of the CodePages dependency

* Bump version to 8.13 RC

* Fixed copy preserving sort order (#10091)

* Revert "Updated LightInject to v6.4.0"

This reverts commit fc77252.

* Revert "Add copy logic to Media Picker (#9957)"

This reverts commit f7c032a.

* Reintroduce old constructor to make non-breaking

* Update cypress test to make macros in the grid work again

* Attributes could be multiple items, test specifically if `Directory` is an attribute

* Accessibility: Adding label fors and control ids for the macro picker (#10101)

* Added support for screeen reader alerts on the embed so that assitive technology knows when a url retrieve has been succesfull.
Added labels for the controls
Preview reload only triggered if the values for height and width change

* Added support for label fors for the macro picker and also gave the ,acro search box a title

* Now displays a count of the matching macros returned. Please note the language file amends shared with #10100

* Removed src-only class for the display of the count of messages

* Updating typo

* Removed top-margin from switcher icon

* Allow KeepAlive controller Ping method to be requested by non local requests (#10126)

* Allow KeepAlive controller Ping method to be requested by non local requests and accept head requests

* removed unused references

* fix csproj

Co-authored-by: Mole <[email protected]>
Co-authored-by: Sebastiaan Janssen <[email protected]>
Co-authored-by: Justin Shearer <[email protected]>
Co-authored-by: Bjarke Berg <[email protected]>
Co-authored-by: Callum Whyte <[email protected]>
Co-authored-by: Shannon <[email protected]>
Co-authored-by: Elitsa Marinovska <[email protected]>
Co-authored-by: patrickdemooij9 <[email protected]>
Co-authored-by: Bjarne Fyrstenborg <[email protected]>
Co-authored-by: Michael Latouche <[email protected]>
Co-authored-by: Nathan Woulfe <[email protected]>
Co-authored-by: Markus Johansson <[email protected]>
Co-authored-by: Jeavon Leopold <[email protected]>
Co-authored-by: Benjamin Carleski <[email protected]>
Co-authored-by: Owain Williams <[email protected]>
Co-authored-by: Jesper Löfgren <[email protected]>
Co-authored-by: Martin Bentancour <[email protected]>
Co-authored-by: Ronald Barendse <[email protected]>
Co-authored-by: Andy Butland <[email protected]>
Co-authored-by: BeardinaSuit <[email protected]>
Co-authored-by: Mads Rasmussen <[email protected]>
Co-authored-by: Rachel Breeze <[email protected]>
Co-authored-by: Dave de Moel <[email protected]>
Co-authored-by: ric <[email protected]>
Co-authored-by: Carole Rennie Logan <[email protected]>
Co-authored-by: Dennis Öhman <[email protected]>
nathanwoulfe added a commit that referenced this pull request Apr 20, 2021
* load only once

* Bump version to 8.6.8

* Initial rework of Lock dictionaries

* [Issue 5277-146] accessibility - Close 'X' icon next to language drop… (#9264)

* [Issue 5277-146] accessibility - Close 'X' icon next to language drop down is identified as "link" - screen reader

* add new loacalization key

* Fix issue with SqlMainDomLock that cannot use implicit lock timeouts … (#9973)

* Fix issue with SqlMainDomLock that cannot use implicit lock timeouts … (#9973)

(cherry picked from commit da5351d)

* Adjust unit tests and apply fixes to scope

* Add more unit tests, showing current issue

* Counting Umbraco.ModelsBuilder and ModelsBuilder.Umbraco namespaces as external providers

* Fix dead lock with TypeLoader

* Fix errors shown in unit tests

* Throw error if all scopes hasn't been disposed

* Clean

* Fixes and Updates for DB Scope and Ambient Context leaks (#9953)

* Adds some scope tests (ported back from netcore) and provides a much better error message, ensure execution context is not flowed to child tasks that shouldn't leak any current ambient context

* updates comment

* Ensure SqlMainDomLock suppresses execution context too

* Since we're awaiting a task in a library method, ConfigureAwait(false)

* missing null check

Co-authored-by: Elitsa Marinovska <[email protected]>

* Adds additional error checking and reporting to MainDom/SqlMainDomLock (#9954)

Co-authored-by: Elitsa Marinovska <[email protected]>

* Add copy logic to Media Picker (#9957)

* Add copy logic to Media Picker

* Add action for copy all

* Fix for selectable media item

* Wrap calls to map in scopes

* Autocomplete scopes

* Remove unnecessary aria-hidden attribute from <umb-icon>

* Remove scope from method that calls another method that has a scope

* Fixes #9993 - Cannot save empty image in Grid

* Clean

* Revert "The Value() method for IPublishedContent was not working with the defaultValue parameter" (#9989)

* Use a hashset to keep track of acquired locks

This simplifies disposing/checking for locks greatly.

* Add images in grid - fixes 9982 (#9987)

Co-authored-by: Sebastiaan Janssen <[email protected]>

* Only create the dicts and hashset when a lock is requested

* Clean

* Adds a config for configuring the access rules on the content dashboard - by default it granted for all user groups

* Adds additional params indicating whether user is admin

* Add images in grid - fixes 9982 (#9987)

Co-authored-by: Sebastiaan Janssen <[email protected]>
(cherry picked from commit e201977)

* Bump version to 8.12.2

* #9964 Removed unneeded check for HttpContext

* Fix for #9950 - HttpsCheck will now retry using the login background image if inital request returns 301/302. Excessvie Headers check will now check the root url instead of the backoffice

* Merge pull request #9994 from umbraco/v8/bugfix/9993

Fixes #9993 - Cannot save empty image in Grid

(cherry picked from commit 0ecc933)

* Apply suggestions from review

* Fixes #9983 - Getting kicked, if document type has a Umbraco.UserPicker property (#10002)

* Fixes #9983

Temporary fix for this issue. using the entityservice like before.

* Needed to remove the call to usersResource here as well for displaying the picked items

* Don't need usersResource for now

* Fixes #9983 - Getting kicked, if document type has a Umbraco.UserPicker property (#10002)

* Fixes #9983

Temporary fix for this issue. using the entityservice like before.

* Needed to remove the call to usersResource here as well for displaying the picked items

* Don't need usersResource for now

(cherry picked from commit 45de0a1)

* 8539: Allow alias in image cropper (#9266)

Co-authored-by: Owain Williams <[email protected]>

* Wrap dumping dictionaries in a method.

* Create method for generating log message

And remove forgotten comments.

* Fix swedish translation for somethingElse.

* Copy member type (#10020)

* Add copy dialog for member type

* Implement copy action for member type

* Create specific localization for content type, media type and member type

* Handle "foldersonly" querystring

* Add button type attribute

* Add a few missing changes of anchor to button element

* Null check on scope and options to ensure backward compatibility

* Improve performance, readability and handling of FollowInternalRedirects (#9889)

* Improve performance, readability and handling of FollowInternalRedirects

* Logger didn't like string param

Passing string param to _logger.Debug<PublishedRouter, int> wasn't happy. Changed to pass existing internalRedirectAsInt variable.

Co-authored-by: Nathan Woulfe <[email protected]>

* Update casing of listview layout name

* 9097 add contextual password helper (#9256)

* update back-office forms

* Display tip on reset password page as well

* add directive for password tip

* integrate directove in login screen

* forgot the ng-keyup :-)

* adapt tooltip directive to potential different Members and Users password settings

* remove watcher

Co-authored-by: Nathan Woulfe <[email protected]>

* Unbind listener

Listening for splitViewRequest was only unbound if the split view editor was opened. Not cleaning up the listener caused a memory leak when changing between nodes as the spit view editor was detached but not garbage-collected

* Replace icon in date picker with umb-icon component (#10040)

* Replace icon in date picker with <umb-icon> component

* Adjust height of clear button

* Update cypress and fix tests

* Listview config icons (#10036)

* Update icons to use <umb-icon> component

* Simplify markup and use disabled button

* Use move cursor style on sortable handle

* Add class for action column

* Update setting auto focus

* Increase font size of umb-panel-header-icon

* Anchor noopener (#10009)

* Set rel="noopener" for anchors with target="_blank"

* Reverted unwanted changes to Default.cshtml

* Align 'Add language' test to netcore

* Add new cypress tests

* Add indentation

* Getting rid of the config file and implementing an appSetting instead

* Implementation for IContentDashboardSettings

* Cleanup

* bool.Try

* Taking AllowContentDashboardAccessToAllUsers prop from GlobalSettings to ContentDashboardSettings and saving AccessRulesFromConfig into a backing field

* fix support for non run states

* Handling multiple values per field in Examine Management

* Add Root<T> and Breadcrumbs extension methods for IPublishedContent (#9033)

* Fix usage of obsolete CreatorName and WriterName properties

* Add generic Root extension method

* Add Breadcrumbs extension methods

* Orders member type grouping of members alphabetically, matching the listing of member types.

* Revert updating deprecated WriterName/CreatorName refs

Changing the properties to use the extensions is a good thing (given the props are deprecated), but causes issues deep in tests. I'm reverting that change to fix the tests, and all refs to the deprecated properties should be updated in one sweep, to deal with any other test issues that might crop up.

* Handle Invalid format for Upgrade check

* Fixes tabbing-mode remains active after closing modal #9790 (#10074)

* Allow to pass in boolean to preventEnterSubmit directive (#8639)

* Pass in value to preventEnterSubmit directive

* Set enabled similar to preventDefault and preventEnterSubmit directives

* Update prevent enter submit value

* Init value from controller

* Use a different default input id prefix for umb-search-filter

* Fix typo

* Check for truthly value

* Revert "Set enabled similar to preventDefault and preventEnterSubmit directives"

This reverts commit 536ce85.

* None pointer events when clicking icon

* Use color variable

* Fixes tabbing-mode remains active after closing modal #9790 (#10074)

(cherry picked from commit c881fa9)

* Null check on scope and options to ensure backward compatibility

(cherry picked from commit fe8cd23)

* Fix validation of step size in integer/numeric field

* 9962: Use $allowedEditors instead of allowed (#10086)

* 9962: Use $allowedEditors instead of allowed

* 9962: Remove redundant statement

* fixes #10021 adds ng-form and val-form-manager to the documentation

* Improved accessibility of link picker (#10099)

* Added support for screeen reader alerts on the embed so that assitive technology knows when a url retrieve has been succesfull.
Added labels for the controls
Preview reload only triggered if the values for height and width change

* Added control ids for the link picker

* Add French translation

* Accessibility: Alerts the user how many results have been returned on a tree search (#10100)

* Added support for screeen reader alerts on the embed so that assitive technology knows when a url retrieve has been succesfull.
Added labels for the controls
Preview reload only triggered if the values for height and width change

* Tree search details the number of search items returned

* Add French translations

* Updated LightInject to v6.4.0

* Remove HtmlSanitizer once more - see #9803

* Also make sure NuGet installs the correct version of the CodePages dependency

* Bump version to 8.13 RC

* Fixed copy preserving sort order (#10091)

* Revert "Updated LightInject to v6.4.0"

This reverts commit fc77252.

* Revert "Add copy logic to Media Picker (#9957)"

This reverts commit f7c032a.

* Reintroduce old constructor to make non-breaking

* Update cypress test to make macros in the grid work again

* Attributes could be multiple items, test specifically if `Directory` is an attribute

* Accessibility: Adding label fors and control ids for the macro picker (#10101)

* Added support for screeen reader alerts on the embed so that assitive technology knows when a url retrieve has been succesfull.
Added labels for the controls
Preview reload only triggered if the values for height and width change

* Added support for label fors for the macro picker and also gave the ,acro search box a title

* Now displays a count of the matching macros returned. Please note the language file amends shared with #10100

* Removed src-only class for the display of the count of messages

* Updating typo

* Removed top-margin from switcher icon

* Allow KeepAlive controller Ping method to be requested by non local requests (#10126)

* Allow KeepAlive controller Ping method to be requested by non local requests and accept head requests

* removed unused references

* fix csproj

* fix merge

* btree serializer optimizations

* array pool and nametable optimizations

Co-authored-by: Mole <[email protected]>
Co-authored-by: Sebastiaan Janssen <[email protected]>
Co-authored-by: Justin Shearer <[email protected]>
Co-authored-by: Bjarke Berg <[email protected]>
Co-authored-by: Callum Whyte <[email protected]>
Co-authored-by: Shannon <[email protected]>
Co-authored-by: Elitsa Marinovska <[email protected]>
Co-authored-by: patrickdemooij9 <[email protected]>
Co-authored-by: Bjarne Fyrstenborg <[email protected]>
Co-authored-by: Michael Latouche <[email protected]>
Co-authored-by: Nathan Woulfe <[email protected]>
Co-authored-by: Markus Johansson <[email protected]>
Co-authored-by: Jeavon Leopold <[email protected]>
Co-authored-by: Benjamin Carleski <[email protected]>
Co-authored-by: Owain Williams <[email protected]>
Co-authored-by: Jesper Löfgren <[email protected]>
Co-authored-by: Martin Bentancour <[email protected]>
Co-authored-by: Ronald Barendse <[email protected]>
Co-authored-by: Andy Butland <[email protected]>
Co-authored-by: BeardinaSuit <[email protected]>
Co-authored-by: Mads Rasmussen <[email protected]>
Co-authored-by: Rachel Breeze <[email protected]>
Co-authored-by: Dave de Moel <[email protected]>
Co-authored-by: ric <[email protected]>
Co-authored-by: Carole Rennie Logan <[email protected]>
Co-authored-by: Dennis Öhman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to move grid block
2 participants