Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #10021 adds ng-form and val-form-manager to the documentation #10083

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

madsrasmussen
Copy link
Contributor

Tabs navigation requires a form and the val-form-manager directive to work. These are not needed if the tabs are used inside a property editor or dashboard. I have added this to the UI documentation.

Screenshot 2021-03-30 at 17 04 16

How to test:

  • Run the UI Documentation from the Umbraco.Web.UI.Docs with gulp watch

@snerpton
Copy link

Perfect, works for me :-)

Copy link
Contributor

@nathanwoulfe nathanwoulfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nathanwoulfe nathanwoulfe changed the base branch from v8/dev to v8/contrib April 5, 2021 21:41
@nathanwoulfe
Copy link
Contributor

Retargeted from v8/dev to v8/contrib since I don't have merge permissions for dev

@nathanwoulfe nathanwoulfe merged commit f549a36 into v8/contrib Apr 5, 2021
@nathanwoulfe nathanwoulfe deleted the v8/bugfix/10021-tabs-docs branch April 5, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants