Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Member groups stopped working #11189

Closed
AaronSadlerUK opened this issue Sep 24, 2021 · 3 comments
Closed

Member groups stopped working #11189

AaronSadlerUK opened this issue Sep 24, 2021 · 3 comments

Comments

@AaronSadlerUK
Copy link
Contributor

AaronSadlerUK commented Sep 24, 2021

Which exact Umbraco version are you using? For example: 8.13.1 - don't just write v8

v9-rc004

Bug summary

When a node is restricted to a member group and the member is in that group, it redirects to the login page.

Specifics

No response

Steps to reproduce

Create a member
Assign member to a group
Restrict public access to a node to the group
Try to access the node with the member

Expected result / actual result

The member should be able to access the node once logged in


This item has been added to our backlog AB#14115

@AaronSadlerUK
Copy link
Contributor Author

Just to add, the sign-in method used is:

var member = await _memberManager.FindByEmailAsync(model.Username);
await _memberSignInManager.SignInAsync(member, false); 

Found in:

private readonly IMemberManager _memberManager;
private readonly IMemberSignInManager _memberSignInManager;

@nul800sebastiaan
Copy link
Member

This isn't working for me either using the partial view macro snippets. When I log in I can see that I'm definitely logged in but going to the protected area kicks me back to the login page.

image

I've made sure to check that the member is in the correct role, should have worked.

@nul800sebastiaan nul800sebastiaan added the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Sep 24, 2021
@nul800sebastiaan
Copy link
Member

I think we're getting the "wrong" HttpContext here somehow. Seems related to #11155

image
image

Shazwazza added a commit that referenced this issue Sep 25, 2021
bergmania added a commit that referenced this issue Sep 26, 2021
* Fixes #11189

* Fixes #11183

* Fix test Null_When_No_Content_On_PublishedRequest.

Believe this is reasonable.

* Update src/Umbraco.Web.Website/Routing/PublicAccessRequestHandler.cs

Co-authored-by: Paul Johnson <[email protected]>
Co-authored-by: Bjarke Berg <[email protected]>
@umbrabot umbrabot removed the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants