Skip to content

Commit

Permalink
[Issue 5277-146] accessibility - Close 'X' icon next to language drop… (
Browse files Browse the repository at this point in the history
#9264)

* [Issue 5277-146] accessibility - Close 'X' icon next to language drop down is identified as "link" - screen reader

* add new loacalization key
  • Loading branch information
justinsane98 authored Mar 12, 2021
1 parent a997f0c commit 85e6a11
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@

<div ng-if="splitViewOpen">
<button type="button" class="btn-reset umb-editor-header__close-split-view" ng-click="closeSplitView()">
<umb-icon icon="icon-delete" class="icon-delete"></umb-icon>
<umb-icon icon="icon-delete" class="icon-delete" aria-hidden="true"></umb-icon>

This comment has been minimized.

Copy link
@bjarnef

bjarnef Mar 13, 2021

Contributor

Actually it doesn't need aria-hidden attribute since the <umb-icon> component itself handle this :)

This comment has been minimized.

Copy link
@bjarnef

bjarnef Mar 16, 2021

Contributor

I have fixed that in #9984

<span class="sr-only"><localize key="general_closepane">Close Pane</localize></span>
</button>
</div>

Expand Down
1 change: 1 addition & 0 deletions src/Umbraco.Web.UI/Umbraco/config/lang/en.xml
Original file line number Diff line number Diff line change
Expand Up @@ -672,6 +672,7 @@
<key alias="clear">Clear</key>
<key alias="close">Close</key>
<key alias="closewindow">Close Window</key>
<key alias="closepane">Close Pane</key>
<key alias="comment">Comment</key>
<key alias="confirm">Confirm</key>
<key alias="constrain">Constrain</key>
Expand Down
1 change: 1 addition & 0 deletions src/Umbraco.Web.UI/Umbraco/config/lang/en_us.xml
Original file line number Diff line number Diff line change
Expand Up @@ -680,6 +680,7 @@
<key alias="clear">Clear</key>
<key alias="close">Close</key>
<key alias="closewindow">Close Window</key>
<key alias="closepane">Close Pane</key>
<key alias="comment">Comment</key>
<key alias="confirm">Confirm</key>
<key alias="constrain">Constrain</key>
Expand Down
1 change: 1 addition & 0 deletions src/Umbraco.Web.UI/Umbraco/config/lang/fr.xml
Original file line number Diff line number Diff line change
Expand Up @@ -636,6 +636,7 @@
<key alias="choose">Choisir</key>
<key alias="close">Fermer</key>
<key alias="closewindow">Fermer la fenêtre</key>
<key alias="closepane">Fermer le panel</key>
<key alias="comment">Commenter</key>
<key alias="confirm">Confirmer</key>
<key alias="constrain">Conserver</key>
Expand Down

0 comments on commit 85e6a11

Please sign in to comment.