Fixed issue with CachedPartial that cached an unmaterialized value, t…

…hat could not be used on cache hits.
umbraco · Aug 11, 2021 · 442310d · 442310d
1 parent c2d54f5
commit 442310d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/src/Umbraco.Web.Common/Extensions/CacheHelperExtensions.cs b/src/Umbraco.Web.Common/Extensions/CacheHelperExtensions.cs
@@ -20,7 +20,7 @@ public static class CacheHelperExtensions
         /// <param name="htmlHelper"></param>
         /// <param name="partialViewName"></param>
         /// <param name="model"></param>
-        /// <param name="cachedSeconds"></param>
+        /// <param name="cacheTimeout"></param>
         /// <param name="cacheKey">used to cache the partial view, this key could change if it is cached by page or by member</param>
         /// <param name="viewData"></param>
         /// <returns></returns>
@@ -30,7 +30,7 @@ public static IHtmlContent CachedPartialView(
             IHtmlHelper htmlHelper,
             string partialViewName,
             object model,
-            int cachedSeconds,
+            TimeSpan cacheTimeout,
             string cacheKey,
             ViewDataDictionary viewData = null)
         {
@@ -41,10 +41,12 @@ public static IHtmlContent CachedPartialView(
                 return htmlHelper.Partial(partialViewName, model, viewData);
             }
 
-            return appCaches.RuntimeCache.GetCacheItem<IHtmlContent>(
+            var result = appCaches.RuntimeCache.GetCacheItem<IHtmlContent>(
                 CoreCacheHelperExtensions.PartialViewCacheKey + cacheKey,
-                () => htmlHelper.Partial(partialViewName, model, viewData),
-                timeout: new TimeSpan(0, 0, 0, cachedSeconds));
+                () => new HtmlString(htmlHelper.Partial(partialViewName, model, viewData).ToHtmlString()),
+                timeout: cacheTimeout);
+
+            return result;
         }
 
     }

diff --git a/...bsite/Extensions/HtmlContentExtensions.cs → ...ommon/Extensions/HtmlContentExtensions.cs b/...bsite/Extensions/HtmlContentExtensions.cs → ...ommon/Extensions/HtmlContentExtensions.cs
diff --git a/src/Umbraco.Web.Website/Extensions/HtmlHelperRenderExtensions.cs b/src/Umbraco.Web.Website/Extensions/HtmlHelperRenderExtensions.cs
@@ -88,7 +88,7 @@ public static async Task<IHtmlContent> CachedPartialAsync(
             this IHtmlHelper htmlHelper,
             string partialViewName,
             object model,
-            int cachedSeconds,
+            TimeSpan cacheTimeout,
             bool cacheByPage = false,
             bool cacheByMember = false,
             ViewDataDictionary viewData = null,
@@ -129,7 +129,7 @@ public static async Task<IHtmlContent> CachedPartialAsync(
             var appCaches = GetRequiredService<AppCaches>(htmlHelper);
             var hostingEnvironment = GetRequiredService<IHostingEnvironment>(htmlHelper);
 
-            return appCaches.CachedPartialView(hostingEnvironment, htmlHelper, partialViewName, model, cachedSeconds, cacheKey.ToString(), viewData);
+            return appCaches.CachedPartialView(hostingEnvironment, htmlHelper, partialViewName, model, cacheTimeout, cacheKey.ToString(), viewData);
         }
 
         // public static IHtmlContent EditorFor<T>(this IHtmlHelper htmlHelper, string templateName = "", string htmlFieldName = "", object additionalViewData = null)