Rename parameter for clarity

umbraco · Oct 5, 2021 · 106f6dc · 106f6dc
1 parent 4eb7579
commit 106f6dc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 12 deletions.
diff --git a/src/Umbraco.Web.UI.Client/src/common/resources/entity.resource.js b/src/Umbraco.Web.UI.Client/src/common/resources/entity.resource.js
@@ -127,7 +127,7 @@ function entityResource($q, $http, umbRequestHelper) {
                'Failed to retrieve url for id:' + id);
         },
 
-        getUrlsByUdis: function(ids, culture) {
+        getUrlsByUdis: function(udis, culture) {
           var query = "culture=" + (culture || "");
 
           return umbRequestHelper.resourcePromise(
@@ -137,9 +137,9 @@ function entityResource($q, $http, umbRequestHelper) {
                      "GetUrlsByUdis",
                      query),
                  {
-                     ids: ids
+                     udis: udis
                  }),
-             'Failed to retrieve url map for ids ' + ids);
+             'Failed to retrieve url map for udis ' + udis);
         },
 
         getUrlByUdi: function (udi, culture) {

diff --git a/src/Umbraco.Web/Editors/EntityController.cs b/src/Umbraco.Web/Editors/EntityController.cs
@@ -238,7 +238,7 @@ public HttpResponseMessage GetUrl(Udi udi, string culture = "*")
         /// <summary>
         /// Get entity URLs by UDIs
         /// </summary>
-        /// <param name="ids">
+        /// <param name="udis">
         /// A list of UDIs to lookup items by
         /// </param>
         /// <param name="culture">The culture to fetch the URL for</param>
@@ -248,14 +248,9 @@ public HttpResponseMessage GetUrl(Udi udi, string culture = "*")
         /// </remarks>
         [HttpGet]
         [HttpPost]
-        public IDictionary<Udi, string> GetUrlsByUdis([FromJsonPath] Udi[] ids, string culture = null)
+        public IDictionary<Udi, string> GetUrlsByUdis([FromJsonPath] Udi[] udis, string culture = null)
         {
-            if (ids == null)
-            {
-                throw new HttpResponseException(HttpStatusCode.NotFound);
-            }
-
-            if (ids.Length == 0)
+            if (udis == null || udis.Length == 0)
             {
                 return new Dictionary<Udi, string>();
             }
@@ -277,7 +272,7 @@ string MediaOrDocumentUrl(Udi udi)
                 };
             }
 
-            return ids
+            return udis
                 .Select(udi => new {
                     Udi = udi,
                     Url = MediaOrDocumentUrl(udi)