Handle default values in dirty check attributes

umbraco · Oct 1, 2020 · 0a5b442 · 0a5b442
1 parent 9a4867d
commit 0a5b442
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/Umbraco.Web.UI.Client/src/common/directives/components/forms/umbcheckbox.directive.js b/src/Umbraco.Web.UI.Client/src/common/directives/components/forms/umbcheckbox.directive.js
@@ -50,7 +50,7 @@
 
         function onInit() {
             vm.inputId = vm.inputId || "umb-check_" + String.CreateGuid();
-            vm.disableDirtyCheck = Object.toBoolean(vm.disableDirtyCheck) === true;
+            vm.disableDirtyCheck = vm.disableDirtyCheck === undefined || Object.toBoolean(vm.disableDirtyCheck) === true;
             vm.icon = vm.icon || vm.iconClass || null;
 
             // If a labelKey is passed let's update the returned text if it's does not contain an opening square bracket [

diff --git a/src/Umbraco.Web.UI.Client/src/common/directives/components/forms/umbradiobutton.directive.js b/src/Umbraco.Web.UI.Client/src/common/directives/components/forms/umbradiobutton.directive.js
@@ -49,7 +49,7 @@
 
         function onInit() {
             vm.inputId = vm.inputId || "umb-radio_" + String.CreateGuid();
-            vm.disableDirtyCheck = Object.toBoolean(vm.disableDirtyCheck) === true;
+            vm.disableDirtyCheck = vm.disableDirtyCheck === undefined || Object.toBoolean(vm.disableDirtyCheck) === true;
             vm.icon = vm.icon || vm.iconClass || null;
 
             // If a labelKey is passed let's update the returned text if it's does not contain an opening square bracket [

diff --git a/src/Umbraco.Web.UI.Client/src/common/directives/validation/nodirtycheck.directive.js b/src/Umbraco.Web.UI.Client/src/common/directives/validation/nodirtycheck.directive.js
@@ -11,7 +11,7 @@ function noDirtyCheck() {
         link: function (scope, elm, attrs, ctrl) {
 
             // If no attribute value is "false", then skip and use default behaviour.
-            var dirtyCheck = Object.toBoolean(attrs.noDirtyCheck) === false;
+            var dirtyCheck = !!attrs.noDirtyCheck && Object.toBoolean(attrs.noDirtyCheck) === false;
             if (dirtyCheck)
                 return;