Skip to content

Commit

Permalink
Pinned Semver version to ensure we have consistent dependency for bui…
Browse files Browse the repository at this point in the history
…lds (#9)

* Pinned Semver version to ensure we have consistent dependency for builds

* Bumped version

* Used 4.8 .NET framework

* Bumped version to new minor.
  • Loading branch information
AndyButland authored Nov 6, 2024
1 parent ce0e580 commit 8396053
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 9 deletions.
10 changes: 5 additions & 5 deletions ps/GetUmbracoBuildEnv.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ $ubuild.DefineMethod("GetUmbracoBuildEnv",
if (-not (test-path $semver))
{
Write-Host "Download Semver..."
$params = "-OutputDirectory", $scriptTemp, "-Verbosity", "quiet", "-Source", $nugetsource
$params = "-Version", "2.3.0", "-OutputDirectory", $scriptTemp, "-Verbosity", "quiet", "-Source", $nugetsource
&$nuget install semver @params
$dir = ls "$scriptTemp\semver.*" | sort -property Name -descending | select -first 1
$file = "$dir\lib\net452\Semver.dll"
Expand Down Expand Up @@ -233,7 +233,7 @@ $ubuild.DefineMethod("GetUmbracoBuildEnv",
$vsVersions = new-object System.Collections.Generic.List[System.Version]

Write-Host "Finding MSbuild.exe"

# parse vswhere output
$params = @()
if ($options.VsPreview) { $params += "-prerelease" }
Expand All @@ -254,9 +254,9 @@ $ubuild.DefineMethod("GetUmbracoBuildEnv",
}
}
if ($vsIx2 -ge 0) {

Write-Host "Detected VS version " $vsVersion.Major

$vsPath = $vsPaths[$vsIx2]

if ($vsVersion.Major -gt 16) {
Expand All @@ -282,7 +282,7 @@ $ubuild.DefineMethod("GetUmbracoBuildEnv",
MsBuild = "$msBuild\MsBuild.exe"
ToolsVersion = $toolsVersion
}

Write-Host "Using MsBuild.exe in $msBuild\MsBuild.exe"
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/SolutionInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@
[assembly: AssemblyVersion("0.2.11")]

// these are FYI and changed automatically
[assembly: AssemblyFileVersion("0.2.18")]
[assembly: AssemblyInformationalVersion("0.2.18")]
[assembly: AssemblyFileVersion("0.3.0")]
[assembly: AssemblyInformationalVersion("0.3.0")]
3 changes: 2 additions & 1 deletion src/Umbraco.Build.Tests/Umbraco.Build.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@
<AppDesignerFolder>Properties</AppDesignerFolder>
<RootNamespace>Umbraco.Build.Tests</RootNamespace>
<AssemblyName>Umbraco.Build.Tests</AssemblyName>
<TargetFrameworkVersion>v4.7.2</TargetFrameworkVersion>
<TargetFrameworkVersion>v4.8</TargetFrameworkVersion>
<FileAlignment>512</FileAlignment>
<TargetFrameworkProfile />
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
<DebugSymbols>true</DebugSymbols>
Expand Down
3 changes: 2 additions & 1 deletion src/Umbraco.Build/Umbraco.Build.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@
<AppDesignerFolder>Properties</AppDesignerFolder>
<RootNamespace>Umbraco.Build</RootNamespace>
<AssemblyName>Umbraco.Build</AssemblyName>
<TargetFrameworkVersion>v4.6.1</TargetFrameworkVersion>
<TargetFrameworkVersion>v4.8</TargetFrameworkVersion>
<FileAlignment>512</FileAlignment>
<TargetFrameworkProfile />
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
<DebugSymbols>true</DebugSymbols>
Expand Down

0 comments on commit 8396053

Please sign in to comment.