Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update is_url() #9566

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Update is_url() #9566

merged 1 commit into from
Sep 23, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Sep 23, 2022

Signed-off-by: Glenn Jocher [email protected]

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhanced URL checking functionality in YOLOv5 utility script.

πŸ“Š Key Changes

  • Renamed the parameter check_online to check_exists in the is_url function.
  • Clarified the function's docstring to better describe its dual purpose: verifying string is a URL and checking its existence.

🎯 Purpose & Impact

  • 🎨 Enhanced code readability and clarity by renaming parameters to better reflect their functionality.
  • πŸ›  Improved documentation helps developers understand the purpose of the code at a glance.
  • 🌐 Reduces the potential for confusion among developers working with YOLOv5's codebase, possibly preventing future bugs related to URL checking.

Signed-off-by: Glenn Jocher <[email protected]>
@glenn-jocher glenn-jocher merged commit 1320ce1 into master Sep 23, 2022
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch September 23, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant