-
-
Notifications
You must be signed in to change notification settings - Fork 16.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --source screen
for screenshot inference
#9542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hello @zombob, thank you for submitting a YOLOv5 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with
ultralytics/yolov5
master
branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by runninggit pull
andgit merge master
locally. - ✅ Verify all YOLOv5 Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee
@zombob this looks good but we want to minimise changes to detect.py, as we’ll need to duplicate any code changes there to segment/predict.py and classify/predict.py. Can you pass the —source screen args to LoadScreenshots and parse args there? |
Fixed. |
God! |
Fixed! Fixed! Fixed! |
Signed-off-by: Glenn Jocher <[email protected]>
Signed-off-by: Glenn Jocher <[email protected]>
Signed-off-by: Glenn Jocher <[email protected]>
Signed-off-by: Glenn Jocher <[email protected]>
Signed-off-by: Glenn Jocher <[email protected]>
Signed-off-by: Glenn Jocher <[email protected]>
--source screen
for screenshot inference
Signed-off-by: Glenn Jocher <[email protected]>
Signed-off-by: Glenn Jocher <[email protected]>
Signed-off-by: Glenn Jocher <[email protected]>
Signed-off-by: Glenn Jocher <[email protected]>
Signed-off-by: Glenn Jocher <[email protected]>
Signed-off-by: Glenn Jocher <[email protected]>
Signed-off-by: Glenn Jocher <[email protected]>
Signed-off-by: Glenn Jocher <[email protected]>
Signed-off-by: Glenn Jocher <[email protected]>
@zombob great to hear that the issue is fixed! Thank you for the update, and we appreciate your efforts in improving YOLOv5. If you have any further questions or need assistance with anything else, feel free to ask. |
add SCREENSHOT as source (isse link)
you can use it like:
Position parameters(left,top) is relative to the "screen"'s left and top,
if you have multiple monitors, the left and top of the screen my be NOT (0,0) !
About the screen can refer to the mss document
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Introducing screenshot detection to YOLOv5 with the new
screen
source option.📊 Key Changes
screen
source keyword.README.md
, notebook, and script help strings to include new screenshot functionality.LoadScreenshots
class for fetching screen captures as a data source.mss
library, which is necessary for screenshot functionality.🎯 Purpose & Impact