-
-
Notifications
You must be signed in to change notification settings - Fork 16.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise error on suffix-less model path #8561
Conversation
@democat3457 the weight suffix is checked here on L520 against the valid ones and an error is thrown if it doesn't match: Lines 516 to 526 in 574ceed
So this PR initially looked like a good idea but I think it's redundant with the above check. |
I see, it seems like the case I had was that the string I passed in had no suffix, so the assert wasn't even being checked - I'll update the check suffix method instead |
@democat3457 ah yes I just remembered! The check_suffix() method has no suffix as one of the acceptable options in case the user passes a directory, like for OpenVINO models. So I think your original PR is probably good. Can you revert the last commit and I'll go ahead and merge? Thanks! |
oh oops, ok then |
@democat3457 PR is merged. Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐ |
Raise error on invalid model
This PR raises an Exception when the model passed into
DetectMultiBackend
does not have a suffix.🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Enforced format support validation in YOLOv5 TensorFlow model conversion.
📊 Key Changes
🎯 Purpose & Impact