-
-
Notifications
You must be signed in to change notification settings - Fork 16.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(utils): missing edge when resample segments #8092
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hello @HRan2004, thank you for submitting a YOLOv5 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with upstream/master. If your PR is behind upstream/master an automatic GitHub Actions merge may be attempted by writing /rebase in a new comment, or by running the following code, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
# git checkout feature # <--- replace 'feature' with local branch name
git merge upstream/master
git push -u origin -f
- ✅ Verify all Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee
@HRan2004 thanks for the PR! Have you trained this successfully with a segmented dataset? |
@glenn-jocher I did not directly use yolov5 to train the segment dataset, but I successfully trained on the modified model and found the bug at this time. There are many modifications, and the GT box is not generated by segment, but predicted the segment directly. Repos address (https://github.com/HRan2004/Yolo-ArbV2) |
@HRan2004 got it, thank you! I will train a segmented dataset to verify. |
Temp experiment tracking at https://wandb.ai/glenn-jocher/test-segmentfix |
@HRan2004 PR shows improved results on segmentation dataset training: |
@HRan2004 PR is merged. It looks like you found and fixed a significant bug in segmentation training! Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐ |
Co-authored-by: Glenn Jocher <[email protected]>
Co-authored-by: Glenn Jocher <[email protected]>
One small problem. When resample segments, missing an edge from the last point to the first.
Eg: https://github.com/HRan2004/Yolo-ArbV2/blob/main/data/images/debug01.png
When the polygon is cut, the missing edge will lead to the wrong position of the GT box.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Enhancement to segment resampling in the YOLOv5 codebase.
📊 Key Changes
🎯 Purpose & Impact