Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_fonts() download to CONFIG_DIR fix #7489

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Apr 20, 2022

Follows #7488. Correct bug where fonts were downloading to current working directory rather than global CONFIG_DIR

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Improved font file handling in Ultralytics' YOLOv5 utility functions.

📊 Key Changes

  • Font file existence check now uses a consolidated file variable.
  • Download log message now references file directly.

🎯 Purpose & Impact

  • Simplified code: Makes the function slightly cleaner and more readable.
  • 🛠️ Consistent logging: Ensures the correct file path is displayed when downloading the font file.
  • 🚀 User experience: Users are better informed about where the font file is being downloaded to, enhancing clarity.

Follows #7488. Correct bug where fonts were downloading to current working directory rather than global CONFIG_DIR
@glenn-jocher glenn-jocher self-assigned this Apr 20, 2022
@glenn-jocher glenn-jocher merged commit ab5b917 into master Apr 20, 2022
@glenn-jocher glenn-jocher deleted the fix/check_fonts branch April 20, 2022 00:50
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
Follows ultralytics#7488. Correct bug where fonts were downloading to current working directory rather than global CONFIG_DIR
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
Follows ultralytics#7488. Correct bug where fonts were downloading to current working directory rather than global CONFIG_DIR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant