Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix volume_status for default source with pamixer #2240

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

oceyral
Copy link
Contributor

@oceyral oceyral commented Mar 12, 2024

Hi,

#2228 and #2230 introduced a regression in volume_status when using it with the default source.

Example configuration chunk :

order += "volume_status mic"

volume_status "mic" {
      is_input = True
      cache_timeout = 1
}

With this configuration, instead of selecting the default source, volume_status selects the default sink by calling pamixer --allow-boost --get-mute --get-volume

This PR adds --default-source to the command in case no device is specified and the option is_input is True.

@oceyral oceyral force-pushed the fix_volume_status_for_input branch from 8c25733 to 3ff25b8 Compare March 13, 2024 09:17
@syyyr
Copy link
Contributor

syyyr commented Mar 13, 2024

Sorry for the regression. I have tested this patch, and my issue (the one I addressed in the PRs) hasn't reappeared.

@ultrabug ultrabug merged commit 878f07d into ultrabug:master Mar 13, 2024
7 checks passed
@ultrabug
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants