Make arch_updates module more responsive to system updates #2215
Conversation
geoffliu
force-pushed
the
gl/arch-package-cache
branch
4 times, most recently
from
4a53386 to
1cb8eb2
Compare
geoffliu
force-pushed
the
gl/arch-package-cache
branch
from
1cb8eb2 to
4b0627a
Compare
|
I trust you as a module user and the logic LGTM thanks! |
| refresh_interval: interval (in seconds) between refreshing data from package | ||
| database or AUR. Note that this module may refresh sooner than the | ||
| specified interval, if pacman log is modified since the last refresh | ||
| time. (default 3600) |
There was a problem hiding this comment.
This shouldn't be renamed just because it gets refreshed sooner. Modules get refreshed sooner all times via clicks, py3-cmd, i3, et cetera. This now ignore people's current cache_timeout setting too.
| format = None | ||
| hide_if_zero = False | ||
| pacman_log_location = "/var/log/pacman.log" |
There was a problem hiding this comment.
(Opinion) I'd like the module to just parse /etc/pacman.conf and grab the log location from there instead.
| self.py3.storage_set(CACHE_KEY_TEXT, full_text) | ||
| self.py3.storage_set(CACHE_KEY_TIMESTAMP, time.time()) | ||
|
|
||
| return {"full_text": full_text} |
There was a problem hiding this comment.
I'm not using Arch right now, but this looks like arch_updates module may be constantly updated all times now... in order to avoid running updater command. Unconfirmed, but something to think about.
The better way just may be to document users to use this hook instead with py3-cmd refresh arch_updates along with either disabled cache_timeout = -1 or longer delay cache_timeout = 3600. https://archlinux.org/pacman/alpm-hooks.5.html
ultrabug#2215)" This reverts commit 24888b3.
ultrabug#2215)" This reverts commit 24888b3.
ultrabug#2215)" This reverts commit 24888b3.
The goal of this PR is that we want to invalidate the cached output of the
arch_updatesmodule after a system update. The gist of the approach is this:cached_untilandcache_timeoutvalues, thus bypassing built-in caching of py3statusThis whole business of bypassing the built-in caching feels a bit dirty, but I'm not familiar with py3status's full module API to know if there's a better approach? @ultrabug What do you think?
Also, now that the module can be more responsive, we can change the default of refresh interval to be longer without degrading user experience