Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for gaea-c5 of modulefiles and scripts #13

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

natalie-perlin
Copy link

@natalie-perlin natalie-perlin commented Nov 15, 2023

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.
  • I am confirming reviews are completed in ALL sub-component PR's.
  • I have run the full RT suite on Gaea-c5, the log file included in the PR tests/logs/RegressionTests_gaea-c5.log and attached
  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
    • LOG:
  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • I have filled out all sections of the template.

Description

Updates of the modulefiles and scripts for the gaea-c5 platform

The following files were added/modified/renamed:

new file:   cmake/configure_gaea-c5.intel.cmake
renamed:    modulefiles/ufs_gaea_c5.intel.lua -> modulefiles/ufs_gaea-c5.intel.lua
modified:   tests/compile.sh
modified:   tests/default_vars.sh
modified:   tests/detect_machine.sh
renamed:    tests/fv3_conf/compile_slurm.IN_gaea_c5 -> tests/fv3_conf/compile_slurm.IN_gaea-c5
renamed:    tests/fv3_conf/fv3_slurm.IN_gaea_c5 -> tests/fv3_conf/fv3_slurm.IN_gaea-c5
new file:   tests/logs/RegressionTests_gaea-c5.log
modified:   tests/module-setup.sh
modified:   tests/rt.sh
modified:   tests/rt_utils.sh
modified:   tests/run_test.sh

Linked Issues and Pull Requests

Associated UFSWM Issue to close

Subcomponent Pull Requests

Blocking Dependencies

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
Tests effected by changes in this PR:

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Jet
    • Gaea
    • Gaea-c5
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@natalie-perlin
Copy link
Author

@ulmononian - please let me know any comments, if anything else may need to be done before the merge!

Copy link
Owner

@ulmononian ulmononian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. thanks for doing these updates/fixes and testing, @natalie-perlin!

@ulmononian ulmononian merged commit 001d965 into ulmononian:feature/add_c5 Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants