Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bench): fix the overlapped name and error in profile generation #827

Merged
merged 37 commits into from
Oct 31, 2024

Conversation

keyangds
Copy link
Collaborator

Closes #

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed
  • Branch name follows type/descript (e.g. feature/add-llm-agents)
  • Ready for code review

ℹ Additional Information

keyangds and others added 30 commits October 22, 2024 22:44
@lwaekfjlk lwaekfjlk changed the title Semantic scholar profile fix(bench): fix the overlapped name and error in profile generation Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 81.48148% with 5 lines in your changes missing coverage. Please review.

Project coverage is 73.03%. Comparing base (820fbb9) to head (1ea3a58).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
research_bench/create_bench_from_conference.py 0.00% 2 Missing ⚠️
research_town/dbs/db_profile.py 50.00% 2 Missing ⚠️
research_town/utils/profile_collector.py 90.90% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #827      +/-   ##
==========================================
- Coverage   73.29%   73.03%   -0.27%     
==========================================
  Files          80       80              
  Lines        3367     3401      +34     
==========================================
+ Hits         2468     2484      +16     
- Misses        899      917      +18     
Files with missing lines Coverage Δ
tests/dbs/test_dbs.py 100.00% <100.00%> (ø)
tests/utils/test_profile_collector.py 100.00% <100.00%> (ø)
research_town/utils/profile_collector.py 89.70% <90.90%> (-8.30%) ⬇️
research_bench/create_bench_from_conference.py 0.00% <0.00%> (ø)
research_town/dbs/db_profile.py 95.38% <50.00%> (-4.62%) ⬇️

... and 1 file with indirect coverage changes

@lwaekfjlk lwaekfjlk merged commit 1ed306b into main Oct 31, 2024
19 checks passed
@lwaekfjlk lwaekfjlk deleted the semantic_scholar-profile branch November 2, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants