Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DBTP-1299 - Cross account database copy #294

Merged
merged 10 commits into from
Dec 3, 2024

Conversation

JohnStainsby
Copy link
Contributor

@JohnStainsby JohnStainsby commented Nov 25, 2024

Addresses https://uktrade.atlassian.net/browse/DBTP-1299

Adds the permissions required for the database copy command to work between environments in different accounts.


Checklist:

Title:

  • Scope included as per conventional commits
  • Ticket reference included (unless it's a quick out of ticket thing)

Description:

  • Link to ticket included (unless it's a quick out of ticket thing)
  • Includes tests (or an explanation for why it doesn't)
  • Includes any applicable changes to the documentation in this code base
  • Includes link(s) to any applicable changes to the documentation in the DBT Platform Documentation (can be to a pull request)

Tasks:

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b0614f4) to head (ad683e8).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #294   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           50        50           
=========================================
  Hits            50        50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohnStainsby JohnStainsby marked this pull request as ready for review November 29, 2024 11:14
@JohnStainsby JohnStainsby requested a review from a team as a code owner November 29, 2024 11:14
@JohnStainsby JohnStainsby merged commit ac84ca8 into main Dec 3, 2024
48 checks passed
@JohnStainsby JohnStainsby deleted the DBTP-1299-cross-account-database-copy branch December 3, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants