fix: DBTP-1534 - Assume role policy for the S3 migration were too strict so relaxing them #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(were assuming demodjango conventions) so I have relaxed them here to allow them to work with arbitrary s3 extension names.
antroy-madetech
changed the title
yusufsheiqh
approved these changes
Nov 13, 2024
WillGibson
reviewed
Nov 13, 2024
WillGibson
approved these changes
Nov 13, 2024
Co-authored-by: Will Gibson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses DBTP-1534
The resources for the assume role were targetting a demodjango naming convention rather than allowing any s3 extension name. This fixes that (but still only targets S3 migration roles).