fix: DBTP-972 Ignored by Checkov baseline #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mramplin
changed the title
gabelton
reviewed
Jul 19, 2024
| from_port = 6379 | ||
| to_port = 6379 | ||
| protocol = "tcp" | ||
| cidr_blocks = [data.aws_vpc.vpc.cidr_block] | ||
| } | ||
| egress { | ||
| description = "Allow all traffic" |
There was a problem hiding this comment.
Not really related to your PR, but does anyone remember why we needed to allow all traffic?
Co-authored-by: Gabe Naughton <[email protected]>
Co-authored-by: Gabe Naughton <[email protected]>
….com/uktrade/terraform-platform-modules into DBTP-972-ignored-by-checkov-baseline
gabelton
reviewed
Aug 19, 2024
gabelton
approved these changes
Aug 19, 2024
Co-authored-by: Gabe Naughton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.