fix: DBTP-1040 - filter prefix terraform variable should be optional #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksugden
changed the title
WillGibson
reviewed
Jul 3, 2024
WillGibson
reviewed
Jul 3, 2024
WillGibson
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
I think we need to document in platform-documentation how to:
- create a rule which applies to all objects in the bucket {} (no prefix of empty string prefix)
- create a set of rules where rule 1 and 2 might include a prefix, and rule 3 has a prefix with an empty string to catch the rest.
Not sure where the best pace for that is now with the new version @rossmiller is working on. Perhaps you could share your branch @rossmiller and we could submit suggestions in pull requests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an omission of the optional qualifier for the terraform filter_prefix variable.
Although the filter is optional in s3 lifecycle rules, it should be specified as an empty block {} if the desire is to apply the rule to all objects in the box. Omitting the optional filter_prefix field in the platform configuration file is permitted. It indicates that the rule should apply to all objects and the empty block should be applied.