fix: DBTP-1089 Move to shared log resource policy #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillGibson
changed the title
WillGibson
commented
Jun 26, 2024
| ] | ||
| } | ||
| CONFIG | ||
| } |
There was a problem hiding this comment.
Unnecessary Log group policy that was actually shared by all environments and destroyed when any one of the environments was destroyed.
ksugden
approved these changes
Jun 26, 2024
|
|
||
| application = var.args.application | ||
| environment = var.environment | ||
| } |
There was a problem hiding this comment.
How come this has moved from extensions to vpc?
There was a problem hiding this comment.
So that we have one log resource policy per VPC instead of one per environment...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://uktrade.atlassian.net/browse/DBTP-1089
TLDR: Will allow us to have more than 10 environments in the same account/region.
@ksugden and @WillGibson have tested this by deploying the
willgenvironment from scratch, checking it's all working and the log groups have the test streams that AWS does.