LTD-5853 unidecode before textwrapping #306
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is mistake, if we notice any other edge cases we could update the new payload file to include them
Tllew
force-pushed
the
LTD-5853-unidecode-before-textwrap
branch
from
ac849e5 to
d18fe1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Things to note:
I had initially added the unidecode to edifact_validators so that the validator could catch the error and went back and forth with this idea for a little while, in theory because it's decoded now in the sanitizer (lite_to_edifact_converter) it will never hit the sanitizer with special characters present.
I have also added some coverage tests in test_builder so that we cant remove this and accidentally have things pass.
if we notice any other edge cases we could update the new payload file to include them
LTD-5853