LTD-4645-healthcheck-app-readd #229
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #229 +/- ##
==========================================
+ Coverage 80.70% 81.01% +0.31%
==========================================
Files 55 55
Lines 3120 3119 -1
Branches 432 432
==========================================
+ Hits 2518 2527 +9
+ Misses 512 502 -10
Partials 90 90 ☔ View full report in Codecov by Sentry. |
| PendingMailHealthCheck, | ||
| ) | ||
|
|
||
| plugin_dir.register(MailboxAuthenticationHealthCheck) | ||
| plugin_dir.register(LicencePayloadsHealthCheck) | ||
| plugin_dir.register(ManageInboxTaskHealthCheck) |
There was a problem hiding this comment.
Is the code for ManageInboxTaskHealthCheck still present? Would suggest removing it if so
There was a problem hiding this comment.
ah no, it was removed when @Tllew merged his PR
There was a problem hiding this comment.
I'm not sure how you can check the manageinbox task as it's all converted to celery, but if it works then happy to keep it in
There was a problem hiding this comment.
We decided to drop the task, but a little confused that it's still referenced here
There was a problem hiding this comment.
Yeah it is a bit confusing to see these references but the code is not there.
| PendingMailHealthCheck, | ||
| ) | ||
|
|
||
| plugin_dir.register(MailboxAuthenticationHealthCheck) | ||
| plugin_dir.register(LicencePayloadsHealthCheck) | ||
| plugin_dir.register(ManageInboxTaskHealthCheck) |
There was a problem hiding this comment.
I'm not sure how you can check the manageinbox task as it's all converted to celery, but if it works then happy to keep it in
done checked on UAT and DEMO both working fine |
a bit of cleaning up since few things were removed when merged.