[LTD-5743] Add line separator to multiple licence condition concatenation #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currycoder
force-pushed
the
LTD-5743-dash-separator-between-OGD-licence-conditions
branch
from
4e237d1 to
697c856
Compare
currycoder
force-pushed
the
LTD-5743-dash-separator-between-OGD-licence-conditions
branch
from
697c856 to
90d503d
Compare
markj0hnst0n
approved these changes
Dec 23, 2024
Comment on lines
+267
to
+271
| { | ||
| "proviso_checkboxes": ["condition_1", "condition_3"], | ||
| "condition_1": "condition 1 abc", | ||
| "condition_3": "condition 3 xyz", | ||
| }, |
There was a problem hiding this comment.
What would happen if we set the text in one of these but didn't tick it?
There was a problem hiding this comment.
As per the form's clean function above; https://github.com/uktrade/lite-frontend/pull/2282/files#diff-49de4a4e2e62ead9382c22236f42efa7e629485e1244644839c1973932159df9R116
This would only add proviso text snippets from text area's which have corresponding checkbox ticks
kevincarrogan
approved these changes
Dec 27, 2024
currycoder
force-pushed
the
LTD-5743-dash-separator-between-OGD-licence-conditions
branch
from
90d503d to
3f7e253
Compare
currycoder
deleted the
LTD-5743-dash-separator-between-OGD-licence-conditions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim
Ensure that the new multiple licence conditions flow concatenates licence conditions with a line separator.
LTD-5743