[LTD-5728] Prevent 'other' radio showing as only option for advice picklist fields #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currycoder
force-pushed
the
LTD-5728-limit-picklist-other
branch
from
5e529a4 to
3711eff
Compare
currycoder
force-pushed
the
LTD-5728-limit-picklist-other
branch
from
9e64ed2 to
2d230f6
Compare
saruniitr
reviewed
Dec 20, 2024
Comment on lines
-100
to
-105
| approval_radios = forms.ChoiceField( | ||
| label="What is your reason for approving?", | ||
| required=False, | ||
| widget=forms.RadioSelect, | ||
| choices=(), | ||
| ) |
There was a problem hiding this comment.
oh this was included in this form by mistake before?
There was a problem hiding this comment.
Yes I believe so. We do not need it at this stage in the wizard
saruniitr
previously approved these changes
Dec 20, 2024
currycoder
force-pushed
the
LTD-5728-limit-picklist-other
branch
2 times, most recently
from
2ff1228 to
362e720
Compare
currycoder
dismissed
saruniitr’s stale review
Radically changed structure subsequent to review
currycoder
force-pushed
the
LTD-5728-limit-picklist-other
branch
from
362e720 to
48ca460
Compare
kevincarrogan
approved these changes
Dec 27, 2024
… have no picklist options
…ere are no picklist conditions
currycoder
force-pushed
the
LTD-5728-limit-picklist-other
branch
from
48ca460 to
8956e15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim
This change ensures that the "Other" option is suppressed when there are no picklist options to choose from for picklist fields in the advice flows. In this situation, rather than seeing the "Other" radio input and an empty textbox, the user just sees the textbox. This should be much clearer.
LTD-5728