Skip to content
This repository has been archived by the owner on Nov 20, 2024. It is now read-only.

bug fix on freeports #1074

Merged

Conversation

timothyPatterson
Copy link
Contributor

Fix bug on EYB CTA not displaying for freeports.

Workflow

Reviewing help

  • Explains how to test locally, including how to set up appropriate data
  • Includes screenshot(s) - ideally before and after, but at least after

Housekeeping

  • Added all new environment variables to Vault.
  • Cleaned up old feature flags
  • Upgraded any vulnerable dependencies.
  • I have updated security dependencies
  • Python requirements have been re-compiled.
  • Frontend assets have been re-compiled.
  • I have checked that my PR is using the latest package versions of: directory-api-client, directory-cms-client, directory-components, directory-forms-api-client, directory-healthcheck, directory-validators

Merging

  • This PR can be merged by reviewers. (If unticked, please leave for the author to merge)

@timothyPatterson timothyPatterson requested a review from a team as a code owner October 25, 2024 14:21
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.76%. Comparing base (c190f90) to head (0620592).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1074   +/-   ##
========================================
  Coverage    98.76%   98.76%           
========================================
  Files           44       44           
  Lines         1947     1947           
========================================
  Hits          1923     1923           
  Misses          24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timothyPatterson timothyPatterson merged commit 130b92b into develop Oct 25, 2024
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants