Skip to content
This repository has been archived by the owner on Nov 20, 2024. It is now read-only.

FIXED https error in xlang selection #1059

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

sebs-code
Copy link
Contributor

@sebs-code sebs-code commented Aug 22, 2024

This ticket fixes the missing 'http / https' in the Xlang selection.

Workflow

  • Ticket exists in Jirahttps://uktrade.atlassian.net/browse/GREATUK-1071
  • Jira ticket has the correct status.
  • A clear/description pull request messaged added.

Reviewing help

  • Explains how to test locally, including how to set up appropriate data
  • Includes screenshot(s) - ideally before and after, but at least after

Housekeeping

  • Added all new environment variables to Vault.
  • Cleaned up old feature flags
  • Upgraded any vulnerable dependencies.
  • I have updated security dependencies
  • Python requirements have been re-compiled.
  • Frontend assets have been re-compiled.
  • I have checked that my PR is using the latest package versions of: directory-api-client, directory-cms-client, directory-components, directory-forms-api-client, directory-healthcheck, directory-validators

Merging

  • This PR can be merged by reviewers. (If unticked, please leave for the author to merge)

@sebs-code sebs-code requested a review from a team as a code owner August 22, 2024 13:34
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.75%. Comparing base (1a1b44a) to head (2cf6015).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1059   +/-   ##
========================================
  Coverage    98.75%   98.75%           
========================================
  Files           44       44           
  Lines         1929     1929           
========================================
  Hits          1905     1905           
  Misses          24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@davidu1975 davidu1975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sebs-code sebs-code merged commit 88c0cb4 into develop Aug 22, 2024
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants