This repository has been archived by the owner on Nov 20, 2024. It is now read-only.
IOO-1175 add data tagging to nav items #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1013 +/- ##
========================================
Coverage 98.79% 98.79%
========================================
Files 45 45
Lines 1987 1987
========================================
Hits 1963 1963
Misses 24 24 ☔ View full report in Codecov by Sentry. |
timothyPatterson
force-pushed
the
IOO-1175-data-tag-navs
branch
from
ee8d2f1 to
aa1e2b3
Compare
stuart-mindt
approved these changes
Feb 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add data-location and data-title attributes to primary and sub navigation to assist with tracking user journeys.
Workflow
Merging