Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

International develop during code control #3741

Draft
wants to merge 57 commits into
base: develop
Choose a base branch
from
Draft

International develop during code control #3741

wants to merge 57 commits into from

Conversation

timothyPatterson
Copy link
Contributor

What

<What is this PR doing, e.g. implementations, algorithms, etc.?>

Why

<Why is this change happening, e.g. goals, use cases, stories, etc.?>

Tick or delete as appropriate:

Workflow

Reviewing help

  • Explains how to test locally, including how to set up appropriate data
  • Includes screenshot(s) - ideally before and after, but at least after
  • Documentation has been updated as necessary
  • Where a PR contains code changes developed or maintained by multiple squads a representative from those squads should review the PR.

Housekeeping

  • Added all new environment variables to Vault.
  • Cleaned up old feature flags
  • Upgraded any vulnerable dependencies.
  • I have updated security dependencies
  • Python requirements have been re-compiled.
  • I have checked that my PR is using the latest package versions of: great-components, directory-constants, directory-healthcheck, directory-validators, directory-components, directory-api-client, directory-ch-client, django-staff-sso-client, directory-forms-api-client, directory-sso-api-client, sigauth

Security

  • Frontend assets have been re-compiled
  • Checked for potential security vulnerabilities
  • Ensured any sensitive data is handled appropriately

Performance

  • Evaluated the performance impact of the changes
  • Ensured that changes do not negatively affect application scalability.

Merging

  • This PR can be merged by reviewers. (If unticked, please leave for the author to merge)

stuart-mindt and others added 10 commits December 18, 2024 08:43
@stuart-mindt stuart-mindt force-pushed the feature-IGUK-2-international-develop-during-code-control branch from 09a660a to b720edb Compare December 18, 2024 08:43
stuart-mindt and others added 13 commits December 18, 2024 13:09
@stuart-mindt @timothyPatterson
IGUK-663 Changing all buttons across international to use design syst…
76b9bd5 
…em ones (#3739)
@timothyPatterson
add debounce to dnb lookup
b67a26a
@timothyPatterson
add throttling to dnb endpoints
cdbbaed
@timothyPatterson
fix flaky test
1710085
@stuart-mindt @timothyPatterson
International select retain focus on reload (#3746)
3bd405c
@stuart-mindt @timothyPatterson
IGUK-736 and IGUK-745 active state fix on investment opps header and …
772c992 
…removing alt on eyb home (#3749)
@timothyPatterson
remove duplicate eyb js imports
a231785
@timothyPatterson
Vendor accessible autocomplete v3.01 because it adds the aria-control…
f265aec 
…s attribute to select components

Use v3.01 throughout International service
@timothyPatterson
fix linter issue with apostrophe on international hcsat leading text …
02384ce 
…argument
@timothyPatterson
refactor iso2->country name dict into countries.js
081708e
@timothyPatterson
link checker for EYB trade associations
c8017f4
@timothyPatterson
Merge pull request #3757 from uktrade/feature-IGUK-662-hide-trade-ass…
d8f2bab 
…ociations-with-broken-links

IGUK-662 hide trade associations with broken links
@timothyPatterson
Merge branch 'develop' into feature-IGUK-2-international-develop-duri…
efb2832 
…ng-code-control
@stuart-mindt stuart-mindt force-pushed the feature-IGUK-2-international-develop-during-code-control branch from efb2832 to 5a87c20 Compare January 2, 2025 10:46
@stuart-mindt stuart-mindt force-pushed the feature-IGUK-2-international-develop-during-code-control branch from 5a87c20 to 8db5af3 Compare January 3, 2025 14:37
timothyPatterson and others added 20 commits January 6, 2025 16:32
@timothyPatterson
refactor article list item into component
f2547e0
@timothyPatterson
use focus styles from great card and refactor article list item into …
18a253d 
…component
@timothyPatterson
add govuk link classes to isd/fas case studies
80e27e4
@timothyPatterson
add govuk link classes to isd/fas case studies
f316014
@timothyPatterson
fix typo
6801516
@timothyPatterson
address qa1
cafe3b7
@timothyPatterson
use article list component for trade associations and event listings
67d8342
@timothyPatterson
address qa2 comments
a29b87b
@stuart-mindt
IGUK-663 Changing all buttons across international to use design syst…
5700457 
…em ones (#3739)
@timothyPatterson @stuart-mindt
add debounce to dnb lookup
27102b8
@timothyPatterson @stuart-mindt
add throttling to dnb endpoints
cac9e7b
@timothyPatterson @stuart-mindt
fix flaky test
36832f7
@stuart-mindt
International select retain focus on reload (#3746)
c5bc03f
@stuart-mindt
IGUK-736 and IGUK-745 active state fix on investment opps header and …
52705a6 
…removing alt on eyb home (#3749)
@timothyPatterson @stuart-mindt
remove duplicate eyb js imports
336bcd9
@timothyPatterson @stuart-mindt
Vendor accessible autocomplete v3.01 because it adds the aria-control…
39542d3 
…s attribute to select components

Use v3.01 throughout International service
@timothyPatterson @stuart-mindt
fix linter issue with apostrophe on international hcsat leading text …
54c74b4 
…argument
@timothyPatterson @stuart-mindt
refactor iso2->country name dict into countries.js
cecada0
@stuart-mindt
Feature IGUK-619 Updating error messages on forms across international (
47f0dfe 
#3764)
@stuart-mindt
Feature IGUK-612 adding legend with hidden label to filters in intern…
c6e842e 
…ational (#3766)
@stuart-mindt stuart-mindt force-pushed the feature-IGUK-2-international-develop-during-code-control branch from 15a4e06 to c6e842e Compare January 8, 2025 11:02
timothyPatterson and others added 9 commits January 8, 2025 15:00
@timothyPatterson
address qa2 comments
216fe47
@timothyPatterson
bci qa3
5f1d846
@timothyPatterson
Merge branch 'feature-IGUK-2-international-develop-during-code-contro…
99c9cc6 
…l' into bug-IGUK-616-link-focus-states
@timothyPatterson
Merge pull request #3767 from uktrade/bug-IGUK-616-link-focus-states
6d882a3 
Accessibility improvements on International (IGUK-616, IGUK-618, IGUK-720)
@stuart-mindt
feature IGUK-480 improving autocomplete JS off for DAC (#3771)
085dfdf
@stuart-mindt
Changing default labels
14ff23f
@timothyPatterson
show more info needed banner
4e9a728 
when a user who registered pre-Dun and Bradstreet integration (03/10/24) signs-in they are redirected to the company lookup screen with a 'more information needed' banner.
@stuart-mindt
Feature IGUK-667 Making fullname, role and telephone number optional …
4d41cbd 
…on EYB triage (#3782)

* Feature IGUK-667 Making fullname, role and telephone number optional on EYB triage
@timothyPatterson
Merge pull request #3783 from uktrade/feature-IGUK-753-dnb-prompt
98edbf3 
IGUK-753 Show more info needed banner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timothyPatterson @stuart-mindt