Update cookie notice #470
Update cookie notice #470
Conversation
Codecov Report
@@ Coverage Diff @@
## master #470 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 43 43
Lines 1911 1911
=======================================
Hits 1865 1865
Misses 46 46Continue to review full report at Codecov.
|
makefile
Outdated
| export FEATURE_DIRECTORY_FORMS_API_ENABLED=true | ||
| export FEATURE_DIRECTORY_FORMS_API_ENABLED=true; \ | ||
| export DIRECTORY_FORMS_API_API_KEY=debug; \ | ||
| export DIRECTORY_FORMS_API_SENDER_ID=debug |
There was a problem hiding this comment.
these should be set in your conf/.env file like so:
.env has advantage over (even placeholder) secrets in makefile:
- no risk of exposing the actual secret by committing makefile changes.
- setting these values in makefile will override other devs' .env file, so they will have to scratch their head then realise and update the makefile
There was a problem hiding this comment.
fair enough. i'll move these
There was a problem hiding this comment.
(.env is a feature of django-environ, and is used when we call env.read_env() in settigns.py)
makefile
Outdated
| @@ -157,7 +159,7 @@ integration_tests: | |||
| cd directory-tests && \ | |||
| make docker_integration_tests | |||
|
|
|||
| compile_requirements: | |||
| compile_all_requirements: | |||
There was a problem hiding this comment.
it's compile_requirements in other repos now, so compile_requirements seems to be the consistent name
https://uktrade.atlassian.net/browse/CMS-148