Replace the legacy format functions with formatDate

[paulgain]

Description of change

This PR replaces the following format functions with the dateFormat function:

• formatMediumDate
• formatMediumDateTime
• formatMediumDateTimeWithoutParsing
• formatLongDate
• formatShortDate
• formatMediumDateParsed

Checklist

• Has the branch been rebased to main?
• Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
• Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

[cypress]

data-hub-frontend    Run #57910

Run Properties:   Passed #57910  •  a376ecc7ed: Fix typo

Project	data-hub-frontend
Branch Review	fix/remove-format-functions
Run status	Passed #57910
Run duration	01m 39s
Commit	a376ecc7ed: Fix typo
Committer	Paul Gain
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	0
Skipped	0
Passing	15
View all changes introduced in this branch ↗︎

[codecov]

Codecov Report

Attention: Patch coverage is 95.94595% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.80%. Comparing base (b77df74) to head (a376ecc).
Report is 36 commits behind head on main.

Files with missing lines	Patch %	Lines
...dules/Contacts/ContactAuditHistory/transformers.js	0.00%	1 Missing ⚠️
...s/Investments/Projects/EditHistory/transformers.js	0.00%	1 Missing ⚠️
...ent/modules/Tasks/TaskDetails/TaskDetailsTable.jsx	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7387      +/-   ##
==========================================
- Coverage   87.98%   87.80%   -0.18%     
==========================================
  Files        1168     1168              
  Lines       18171    18163       -8     
  Branches     5138     5136       -2     
==========================================
- Hits        15987    15948      -39     
- Misses       2184     2215      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[baarkerlounger]

Worth adding tests for the missing lines?

[oliverjwroberts]

Looks good to me. Had a couple of comments, but nothing blocking the PR.

[peterhudec]

Worth adding tests for the missing lines?

We turned off the coverage as a required check so I'm not sure whether we really need to make all those lines covered. But the coverage report reveals some fundamental issues with our code:

How can created_on ever be null? Was it never created? Or has it not been created yet?

Does it make sense for interaction.date to be empty? What kind of interaction would that be?
.../modules/Companies/CompanyActivity/transformers.js

Should we really validate date strings in ad hoc places and just fall back to a not set placeholder if it is invalid? All the dates come data-hub-api, don't we trust that service? If the API gives us invalid dates, this is a problem and the FE should not brush it under the carpet as a not set value.
...dules/Contacts/ContactAuditHistory/transformers.js

[baarkerlounger]

@peterhudec it looks like created_on is a nullable field at the backend database level in most cases. There might be cases where it's not set if the record hasn't been created through the Django ORM - though that probably shouldn't really be happening.

[paulgain]

Worth adding tests for the missing lines?

@baarkerlounger I've fixed 3 of these, however, there are still 3 outstanding, the top 2 will be addressed in the next PR as I need to remove the isUnparsedDateValid function. The last one is covered by component tests (see the links below), component tests have not been instrumented by nyc so they do not show up in the Codecov report.
https://github.com/uktrade/data-hub-frontend/blob/main/test/component/cypress/specs/Tasks/TaskDetails/TaskDetailsTable.cy.jsx#L45
https://github.com/uktrade/data-hub-frontend/blob/main/test/component/cypress/specs/Tasks/TaskDetails/TaskDetailsTable.cy.jsx#L88

[paulgain]

@peterhudec and I jumped on a call to discuss his comments in detail 😄 .