Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed all occurences of qs.parse #6728

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

peterhudec
Copy link
Contributor

Description of change

Document what the PR does and why the change is needed

Test instructions

What should I see?

Screenshots

Before

Add a screenshot

After

Add a screenshot

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

Copy link

cypress bot commented Apr 18, 2024

1 failed test on run #52892 ↗︎

1 76 0 0 Flakiness 0

Details:

Removed all occurences of qs.parse
Project: data-hub-frontend Commit: 5558273908
Status: Failed Duration: 11:27 💡
Started: Apr 18, 2024 1:05 PM Ended: Apr 18, 2024 1:16 PM
Failed  test/end-to-end/cypress/specs/DIT/local-nav-spec.js • 1 failed test

View Output Video

Test Artifacts
DBT Permission > activity > when on the activity tab, internal activity should be selected Test Replay Video

Review all test suite changes for PR #6728 ↗︎

@peterhudec peterhudec force-pushed the fix/remove-qs-dependency branch from 005b56f to 5558273 Compare April 18, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant