Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Company Export link for Interactions. #5858

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

elcct
Copy link
Contributor

@elcct elcct commented Dec 13, 2024

Description of change

This adds ability to link Company Exports to Interactions.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@elcct elcct requested a review from a team as a code owner December 13, 2024 15:49
Copy link
Contributor

@code-review-doctor code-review-doctor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some food for thought. View full project report here.

datahub/interaction/test/views/test_interaction_v4.py Outdated Show resolved Hide resolved
datahub/interaction/test/views/test_service_delivery.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.64%. Comparing base (e5396bb) to head (8304885).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5858   +/-   ##
=======================================
  Coverage   96.63%   96.64%           
=======================================
  Files        1057     1058    +1     
  Lines       25145    25160   +15     
  Branches     1668     1669    +1     
=======================================
+ Hits        24300    24315   +15     
  Misses        689      689           
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant