Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix business potential returned by company export wins endpoint. #5616

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elcct
Copy link
Contributor

@elcct elcct commented Sep 3, 2024

Description of change

This returns business potential name instead of business potential legacy export wins id.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@elcct elcct requested a review from a team as a code owner September 3, 2024 07:55
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (adab1a2) to head (d7b2559).
Report is 409 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5616   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files         974      974           
  Lines       22995    22995           
  Branches     2064     2064           
=======================================
  Hits        22130    22130           
+ Misses        706      705    -1     
- Partials      159      160    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants