Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed tohsin to i_t_current_ramp_up #3558

Merged

Conversation

j-a-foster
Copy link
Collaborator

@j-a-foster j-a-foster commented Feb 24, 2025

Description

Renames tohsin to i_t_current_ramp_up to adhere to PROCESS standards.


Variables

  • tohsin -> i_t_current_ramp_up: To match PROCESS style guide

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@j-a-foster j-a-foster linked an issue Feb 24, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 31.19%. Comparing base (6fc1dea) to head (2aabb3e).

Files with missing lines Patch % Lines
process/physics.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3558   +/-   ##
=======================================
  Coverage   31.19%   31.19%           
=======================================
  Files          83       83           
  Lines       19937    19936    -1     
=======================================
  Hits         6220     6220           
+ Misses      13717    13716    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@athoynilimanew athoynilimanew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Anyone with merging permission can merge it now :)

@j-a-foster j-a-foster merged commit 8966166 into main Feb 24, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tohsin does not meet new PROCESS coding standards
3 participants