Rename scaled itv bounds #3557
Merged
Rename scaled itv bounds #3557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
timothy-nunn
force-pushed
the
3529-numerics-bounds-names
branch
from
822583c to
425f1bf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3557 +/- ##
=======================================
Coverage 31.19% 31.19%
=======================================
Files 83 83
Lines 19937 19937
=======================================
Hits 6220 6220
Misses 13717 13717 ☔ View full report in Codecov by Sentry. |
timothy-nunn
force-pushed
the
3529-numerics-bounds-names
branch
from
425f1bf to
9d6cccc
Compare
clmould
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scaled itv lower and upper bounds were too similar to their non-scaled counterparts, leading to bugs and confusion (e.g. when I was converting scan).