Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make objective function plot optional #3231

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make objective function plot optional #3231

wants to merge 1 commit into from

Conversation

jonmaddock
Copy link
Contributor

Allows plotting solutions with different objective functions.

@jonmaddock
Make objective function plot optional
5166cab 
Allows plotting solutions with different objective functions
@jonmaddock jonmaddock self-assigned this Jun 21, 2024
@jonmaddock jonmaddock linked an issue Jun 21, 2024 that may be closed by this pull request
Plot solutions with different objective functions in plot_solutions.py #3230
Open
@jonmaddock jonmaddock requested a review from timothy-nunn June 24, 2024 11:50
timothy-nunn
timothy-nunn requested changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jon,

When running plot_mfile_solutions with rmse=True and plot_obj_func=False I get an UnboundLocalError. Could you either fix this or raise a ValueError if this combination of arguments is illegal.

Code otherwise looks fine and works when rmse=False

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothy-nunn timothy-nunn timothy-nunn requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@jonmaddock jonmaddock

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plot solutions with different objective functions in plot_solutions.py
2 participants
@jonmaddock @timothy-nunn