feat: Added Hue XY Conversions #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tynopia Thank you for your PR! I took some time to learn about XY color values after reviewing your submission, and I think it's a great addition. I’ll go ahead and merge it! |
|
Thank you 🎊 I’m making some updates to the documentation and realized I forgot to include the color() function. So i will also add this |
|
@Tynopia The test cases did not pass. |
|
Yeah, give me 10 min 👍 |
|
Oops, I'll never say 10 minutes again if it takes 3 hours 😆 . I now have a fix and everything should work now |
|
Fixed |
jaywcjlove
added a commit
that referenced
this pull request
Sep 22, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 22, 2024
* feat: Added Hue XY Conversions * feat: Added Docs * fix: Changed sRGB Logic * fix: Added XY to Circle colors test 8643165
|
@Tynopia thx! |
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! 😃
First of all, I want to express my appreciation for this amazing repository, it has saved me hours of work!
I am currently working on a Philips Hue Controller that can send the XY color values derived from the HEX values provided by your UI. To achieve this, I referred to the official Philips documentation and implemented the following XY conversion functions:
hexToXYxyToHexrgbToXYxyToRgbI hope you find these additions useful!