Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Github picker placement enum: "Botton" instead of "Bottom" #131

Closed
manuel-mauky opened this issue Nov 3, 2023 · 1 comment
Closed

Comments

@manuel-mauky
Copy link

In the GithubPlacement enum there is a typo the word "Bottom" in several combinations.

export enum GithubPlacement {
  Left = 'L',
  LeftTop = 'LT',
  LeftBotton = 'LB',
  Right = 'R',
  RightTop = 'RT',
  RightBotton = 'RB',
  Top = 'T',
  TopRight = 'TR',
  TopLeft = 'TL',
  Botton = 'B',
  BottonLeft = 'BL',
  BottonRight = 'BR',
}

Not sure if you want to change this as it would mean a API breaking change. You could add the correctly spelled keys mapping to the same string values though.

@jaywcjlove
Copy link
Member

@manuel-mauky update v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants